Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP patch version ignored #704

Closed
2 of 5 tasks
Bilge opened this issue Feb 20, 2023 · 2 comments
Closed
2 of 5 tasks

PHP patch version ignored #704

Bilge opened this issue Feb 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request needs-funding

Comments

@Bilge
Copy link

Bilge commented Feb 20, 2023

Describe the bug
This action only cares about the PHP major/minor version, but ignores the patch version (major.minor.patch).

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems
ubuntu-latest

PHP versions
8.1.13

To Reproduce

jobs:
  Test:
    strategy:
      matrix:
        php:
          - 8.1.13
          - 8.2.0

    runs-on: ubuntu-latest
    steps:
      - name: Setup PHP ${{ matrix.php }}
        uses: shivammathur/setup-php@v2
        with:
          php-version: ${{ matrix.php }}

Expected behavior
Install exact PHP version (including patch version).

Screenshots/Logs
image

Additional context
https://github.com/Provider/Steam/actions/runs/4223861211/jobs/7334088925

Are you willing to submit a PR?
No lol

@Bilge Bilge added the bug Something isn't working label Feb 20, 2023
@shivammathur
Copy link
Owner

Duplicate #687

@shivammathur shivammathur added enhancement New feature or request needs-funding and removed bug Something isn't working labels Feb 20, 2023
@Bilge
Copy link
Author

Bilge commented Feb 20, 2023

I would appreciate if you did not just close this without comment. If you're not going to support this then, at the very least, specifying a patch version should result in an error, because the current behaviour (rounding up to the latest version) is definitely not a good, desirable or expected behaviour. If patch version is specified but not supported then stop and throw an error back to the user to let them know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-funding
Projects
None yet
Development

No branches or pull requests

2 participants