Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select an old patch version of PHP #687

Closed
2 of 5 tasks
phil-davis opened this issue Jan 20, 2023 · 3 comments
Closed
2 of 5 tasks

Select an old patch version of PHP #687

phil-davis opened this issue Jan 20, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request needs-funding

Comments

@phil-davis
Copy link

Describe the bug
I want run PHP 8.1.13 and not 8.1.14 because of PHP issue php/php-src#10218 that is fixed in commit php/php-src@d12ba11 but the next PHP 8.1.15 is not yet released.

See sabre-io/vobject#604

Version

  • I have checked releases, and the bug exists in the latest patch version of v1 or v2.
  • v2
  • v1

Runners

  • GitHub Hosted
  • Self Hosted

Operating systems

PHP versions
I an trying to use 8.1.13

To Reproduce
I have put
php-version: 8.1.13
update: false
in https://github.com/sabre-io/vobject/blob/master/.github/workflows/ci.yml

Expected behavior
The workflow ends up using PHP 8.1.13

Screenshots/Logs
https://github.com/sabre-io/vobject/actions/runs/3964660146/jobs/6793716785

/usr/bin/bash /home/runner/work/_actions/shivammathur/setup-php/v2/src/scripts/run.sh

==> Setup PHP
✓ PHP Updated to PHP 8.1.14

I still get PHP 8.1.14

Additional context

Are you willing to submit a PR?
Yes, if there is something that can be done about this.

How do I successfully specify an "old" PHP patch version?

@phil-davis
Copy link
Author

I am not sure if this is a bug or an unimplemented feature!

@phil-davis phil-davis changed the title Select and old patch version of PHP Select an old patch version of PHP Jan 20, 2023
@shivammathur
Copy link
Owner

@phil-davis
This would be a feature I cannot support currently. More about that here #618

As an alternative till we have a new PHP version, please specify a container with PHP 8.1. We maintain setupphp/node images for setup-php to run on self-hosted environments and they can be used in this situation.
https://hub.docker.com/repository/docker/setupphp/node/tags

jobs:
  test:
    runs-on: ubuntu-latest
    container: setupphp/node@sha256:32a6c9fc7882993822650c62ef8f8cb5202a2827f92c07687d68cfc80140c849
    steps:
      - name: Setup PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: `8.1`

@shivammathur shivammathur added enhancement New feature or request needs-funding and removed bug Something isn't working labels Jan 21, 2023
@jrfnl
Copy link
Contributor

jrfnl commented Mar 21, 2023

For anyone trying to get to the Docker images - the above URL does not work.
This one should: https://hub.docker.com/r/setupphp/node/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-funding
Projects
None yet
Development

No branches or pull requests

3 participants