-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Asyncio] Test suite is failing #78
Comments
Hmm, I'll take a look at this, thanks. :) |
Closed
Merged
Rixxan
added a commit
to Rixxan/pydle
that referenced
this issue
May 6, 2022
Per Requests, removing the mock event loop. Pydle no longer rolls its own event loop, because Pydle is a good little program.
Rixxan
added a commit
to Rixxan/pydle
that referenced
this issue
May 6, 2022
Rixxan
added a commit
to Rixxan/pydle
that referenced
this issue
May 7, 2022
This segment was causing all sorts of "was not awaited" warnings, however removing it seems to have resolved these issues. I think it's an artefact from when Pydle was running its own event loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While investigating what it would take to enable 3.7 compatibility, I discovered the test suite is not currently in a passing state and, therefore, it is not possible to reliably prove any fix would take effect without introducing bugs / breaking behaviors.
This is very worrying, as my organization is building a IRC bot using this library that cannot blow up randomly do to an undetected bug in the underlying IRC infrastructure. As the tests are not passing, the stability of this project cannot be reliably proven. While Pydle appears to function as it is documented based on integration tests, It may prove difficult to both maintain the project and upgrade it without passing tests.
Environment:
Windows 10 x64, Linux
python x64 v
3.6.3
and3.6.6
Test summery:
Full error output: gist
looks like there is an issue somewhere in
MockClient._connect
, however I have been unable to narrow it down.My apologies for wasting your time should this already be a known issue, for I am unable to find any reference to tests in recent issue tickets.
The text was updated successfully, but these errors were encountered: