refactor: change naming for component embed operation and expose the …

…configuration interface for `embedComponent()`
shlomiassaf · Aug 30, 2016 · 64b1eb8 · 64b1eb8
1 parent c80ec4e
commit 64b1eb8
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/src/components/angular2-modal/index.ts b/src/components/angular2-modal/index.ts
@@ -28,6 +28,7 @@ export {
 
 export {
   Overlay,
+  EmbedComponentConfig,
   ModalOverlay,
   OverlayDialogBoundary,
   OverlayTarget

diff --git a/src/components/angular2-modal/overlay/index.ts b/src/components/angular2-modal/overlay/index.ts
@@ -1,4 +1,4 @@
 export { OverlayTarget, OverlayDialogBoundary, DefaultOverlayTarget } from './overlay.directives'
-export { ModalOverlay } from './overlay.component';
+export { ModalOverlay, EmbedComponentConfig } from './overlay.component';
 export { Overlay } from './overlay.service';
 
diff --git a/src/components/angular2-modal/overlay/overlay.component.ts b/src/components/angular2-modal/overlay/overlay.component.ts
@@ -18,11 +18,12 @@ import { DialogRef } from '../models/dialog-ref';
 import { BaseDynamicComponent } from '../components/index';
 
 
-interface ComponentLinkerData {
+export interface EmbedComponentConfig {
   component: any;
   bindings?: ResolvedReflectiveProvider[];
   projectableNodes?: any[][];
 }
+
 /**
  * Represents the modal overlay.
  */
@@ -53,9 +54,9 @@ export class ModalOverlay extends BaseDynamicComponent {
   }
 
 
-  addEmbeddedComponent(linkData: ComponentLinkerData): EmbeddedViewRef<ComponentLinkerData> {
+  embedComponent(config: EmbedComponentConfig): EmbeddedViewRef<EmbedComponentConfig> {
     return this.vcr.createEmbeddedView(this.template, {
-      $implicit: linkData
+      $implicit: config
     });
   }
 

diff --git a/src/components/angular2-modal/providers/modal.ts b/src/components/angular2-modal/providers/modal.ts
@@ -94,7 +94,7 @@ export abstract class Modal {
     } else if (content instanceof TemplateRef) {
       nodes = [this.overlay.defaultViewContainer.createEmbeddedView(content, { dialogRef }).rootNodes];
     } else {
-      nodes = [dialogRef.overlayRef.instance.addEmbeddedComponent({ component: content, bindings: b }).rootNodes];
+      nodes = [dialogRef.overlayRef.instance.embedComponent({ component: content, bindings: b }).rootNodes];
     }
     return dialogRef.overlayRef.instance.addComponent<T>(ContainerComponent, b, nodes);
   }