-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support arm64 linux runners #1031
Conversation
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (12)
You can disable this status message by setting the WalkthroughThe pull request modifies multiple GitHub Actions workflow configurations to expand the build matrix by adding ARM-based Ubuntu environments. Specifically, the operating system Changes
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/test.yml
(2 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/test.yml
15-15: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
16-16: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
64-64: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
65-65: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
.github/workflows/test.yml
[failure] 15-15:
[actionlint] reported by reviewdog 🐶
label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:15:13: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
[failure] 16-16:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:16:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
[failure] 64-64:
[actionlint] reported by reviewdog 🐶
label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:64:13: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
[failure] 65-65:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:65:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
🪛 GitHub Actions: reviewdog
.github/workflows/test.yml
[error] 15-15: Unknown runner label 'ubuntu-24.04-arm'. Please use one of the available GitHub runner labels.
[error] 16-16: Unknown runner label 'ubuntu-22.04-arm'. Please use one of the available GitHub runner labels.
[error] 49-49: Missing required file 'lib/setup-redis.js' specified in the 'main' key of the action.
[error] 49-49: Missing required file 'lib/cleanup-redis.js' specified in the 'post' key of the action.
[error] 64-64: Unknown runner label 'ubuntu-24.04-arm'. Please use one of the available GitHub runner labels.
[error] 65-65: Unknown runner label 'ubuntu-22.04-arm'. Please use one of the available GitHub runner labels.
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: test-tls (macos-13, 7.4)
- GitHub Check: test-tls (macos-13, 7.0)
- GitHub Check: test-tls (macos-13, 6.2)
- GitHub Check: test-tls (macos-14, 7.2)
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
.github/workflows/test.yml (2)
Line range hint
42-42
: Ensure build step generates required action filesThe pipeline is failing because required action files are missing. The
npm run build
step should generate these files:
- lib/setup-redis.js
- lib/cleanup-redis.js
Please verify that:
- The build step is working correctly
- The generated files are included in the repository
Run this script to check the build process:
🧰 Tools
🪛 actionlint (1.7.4)
15-15: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
16-16: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 15-15:
[actionlint] reported by reviewdog 🐶
label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/test.yml:15:13: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
[failure] 16-16:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/test.yml:16:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]🪛 GitHub Actions: reviewdog
[error] 15-15: Unknown runner label 'ubuntu-24.04-arm'. Please use one of the available GitHub runner labels.
[error] 16-16: Unknown runner label 'ubuntu-22.04-arm'. Please use one of the available GitHub runner labels.
Line range hint
8-24
: Verify Redis compatibility with ARM64 architectureSince this PR adds ARM64 runner support, please ensure that:
- All Redis versions in the test matrix (6.2, 7.2, and Valkey) are compatible with ARM64
- The action's Redis installation process supports ARM64 binaries
Run this script to check Redis ARM64 compatibility:
✅ Verification successful
ARM64 support is properly implemented ✅
The build scripts explicitly support ARM64 architecture and compile Redis from source with proper architecture detection. Both Redis and its OpenSSL dependency are built natively for the target architecture, ensuring full compatibility with ARM64 runners.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if Redis versions support ARM64 for version in "6.2" "7.2" "valkey-8.0"; do echo "Checking Redis $version..." curl -s "https://api.github.com/repos/redis/redis/releases/tags/$version" | \ jq -r '.assets[] | select(.name | contains("arm64")) | .name' doneLength of output: 878
Script:
#!/bin/bash # Find Redis setup action and its version in the workflow echo "Checking workflow for Redis setup..." cat .github/workflows/test.yml # Check if there are any Redis-related setup files echo -e "\nChecking for Redis setup scripts..." fd -t f -e sh -e bash redisLength of output: 3305
Script:
#!/bin/bash # Check Redis build scripts for architecture handling echo "=== Checking build-redis.sh ===" cat build-redis.sh echo -e "\n=== Checking build-redis-with-openssl1.1.sh ===" cat build-redis-with-openssl1.1.sh echo -e "\n=== Checking build-redis-with-openssl3.sh ===" cat build-redis-with-openssl3.shLength of output: 7299
🧰 Tools
🪛 actionlint (1.7.4)
15-15: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
16-16: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 15-15:
[actionlint] reported by reviewdog 🐶
label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/test.yml:15:13: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
[failure] 16-16:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/test.yml:16:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]🪛 GitHub Actions: reviewdog
[error] 15-15: Unknown runner label 'ubuntu-24.04-arm'. Please use one of the available GitHub runner labels.
[error] 16-16: Unknown runner label 'ubuntu-22.04-arm'. Please use one of the available GitHub runner labels.
- ubuntu-24.04-arm | ||
- ubuntu-22.04-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update runner labels to use correct GitHub-hosted runner syntax
The current labels ubuntu-24.04-arm
and ubuntu-22.04-arm
are not recognized by GitHub Actions. For ARM64 support, use the official GitHub-hosted runner labels:
Apply this diff to fix the runner labels:
- - ubuntu-24.04-arm
- - ubuntu-22.04-arm
+ - ubuntu-latest-arm64
+ - ubuntu-22.04-arm64
Note: Currently, GitHub only supports ubuntu-latest-arm64
and ubuntu-22.04-arm64
for ARM64 runners. Ubuntu 24.04 is not yet available for ARM64.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- ubuntu-24.04-arm | |
- ubuntu-22.04-arm | |
- ubuntu-latest-arm64 | |
- ubuntu-22.04-arm64 |
🧰 Tools
🪛 actionlint (1.7.4)
15-15: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
16-16: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 15-15:
[actionlint] reported by reviewdog 🐶
label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:15:13: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
[failure] 16-16:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:16:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
🪛 GitHub Actions: reviewdog
[error] 15-15: Unknown runner label 'ubuntu-24.04-arm'. Please use one of the available GitHub runner labels.
[error] 16-16: Unknown runner label 'ubuntu-22.04-arm'. Please use one of the available GitHub runner labels.
- ubuntu-24.04-arm | ||
- ubuntu-22.04-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply the same runner label updates to the test-tls job
For consistency, update the runner labels in the test-tls job matrix to match the changes in the test job.
Apply this diff:
- - ubuntu-24.04-arm
- - ubuntu-22.04-arm
+ - ubuntu-latest-arm64
+ - ubuntu-22.04-arm64
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- ubuntu-24.04-arm | |
- ubuntu-22.04-arm | |
- ubuntu-latest-arm64 | |
- ubuntu-22.04-arm64 |
🧰 Tools
🪛 actionlint (1.7.4)
64-64: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
65-65: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 64-64:
[actionlint] reported by reviewdog 🐶
label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:64:13: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
[failure] 65-65:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/test.yml:65:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
🪛 GitHub Actions: reviewdog
[error] 64-64: Unknown runner label 'ubuntu-24.04-arm'. Please use one of the available GitHub runner labels.
[error] 65-65: Unknown runner label 'ubuntu-22.04-arm'. Please use one of the available GitHub runner labels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
.github/workflows/build-redis-2.8.yml (1)
Add architecture constraint for Redis 2.8.x builds
Redis 2.8.x predates widespread ARM64 adoption and lacks official ARM64 support. To prevent potential issues:
- Add the following condition to skip ARM64 builds for Redis 2.8.x:
if: | !(matrix.os == 'ubuntu-22.04-arm' && startsWith(matrix.redis, '2.8.'))🔗 Analysis chain
Line range hint
20-45
: Verify Redis 2.8.x compatibility with ARM64Redis 2.8.x is quite old. We should verify its compatibility with ARM64 architecture.
Additionally, consider adding a version check in the workflow:
if: | !(matrix.os == 'ubuntu-22.04' && matrix.redis < '3.0.0' && runner.arch == 'arm64')🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the build script has ARM-specific configurations rg -l "arm|aarch" build-redis.sh # Look for any version-specific compile flags rg -A 5 "2\.8\." build-redis.sh # Check for any documented ARM support in older Redis versions curl -s https://raw.githubusercontent.com/redis/redis/2.8/README.md | grep -i "arm"Length of output: 152
Script:
#!/bin/bash # Find build-related files fd -t f "build.*redis" . # Search for ARM or architecture-related configurations in workflow files rg -A 5 "arm|aarch|arch" .github/workflows/ # Search for Redis version handling in workflow files rg -A 5 "redis.*version|version.*redis" .github/workflows/ # Look for any architecture-specific build configurations rg -l "arch|platform|arm|aarch" .Length of output: 21923
Script:
#!/bin/bash # Check build script for compilation settings cat build-redis.sh # Look for any ARM-specific compilation flags or configurations rg -A 5 "CFLAGS|make|configure" build-redis.sh # Check if there are any ARM-specific patches rg -l "arm|aarch" patches/redis/2.8.*Length of output: 2997
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-2.8.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]🪛 GitHub Actions: reviewdog
[error] 17-17: Unknown runner label 'ubuntu-22.04-arm'. Configure custom labels in actionlint.yaml if using self-hosted runner.
🧹 Nitpick comments (2)
.github/workflows/build-redis-3.0.yml (1)
17-17
: Consider documenting ARM64 support requirements.Since this is a significant architecture addition:
- Consider adding ARM64-specific build requirements or limitations to the README.
- Document any dependencies that need ARM64 variants.
- Consider adding ARM64-specific test cases.
Would you like me to help create documentation for ARM64 support requirements?
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-3.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label].github/workflows/build-redis-2.8.yml (1)
Line range hint
1-85
: Consider adding architecture-specific test stepTo ensure the built binaries work correctly on ARM64, consider adding a basic test step that verifies the Redis server starts and can handle basic operations.
- uses: actions/attest-build-provenance@v2 with: subject-path: ${{ runner.temp }}/*.tar.zstd + + - name: Test Redis Binary + if: runner.arch == 'arm64' + run: | + tar -I zstd -xf "$RUNNER_TEMP/redis-bin.tar.zstd" + ./redis-server --version + ./redis-server --test-memory 1🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-2.8.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]🪛 GitHub Actions: reviewdog
[error] 17-17: Unknown runner label 'ubuntu-22.04-arm'. Configure custom labels in actionlint.yaml if using self-hosted runner.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.github/workflows/build-redis-2.8.yml
(1 hunks).github/workflows/build-redis-3.0.yml
(1 hunks).github/workflows/build-redis-3.2.yml
(1 hunks).github/workflows/build-redis-4.0.yml
(1 hunks).github/workflows/build-redis-5.0.yml
(1 hunks).github/workflows/build-redis-6.0.yml
(1 hunks).github/workflows/build-redis-6.2.yml
(1 hunks).github/workflows/build-redis-7.0.yml
(1 hunks).github/workflows/build-redis-7.2.yml
(1 hunks).github/workflows/build-redis-7.4.yml
(1 hunks).github/workflows/build-valkey-7.2.yml
(1 hunks).github/workflows/build-valkey-8.0.yml
(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/build-redis-5.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-valkey-8.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-2.8.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-6.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.4.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-valkey-7.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-3.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-6.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-4.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-3.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
.github/workflows/build-redis-5.0.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-5.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-2.8.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-2.8.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-6.2.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-6.2.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-3.0.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-3.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-7.0.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-7.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-7.2.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-7.2.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-6.0.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-6.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-4.0.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-4.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/build-redis-3.2.yml
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-3.2.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
🪛 GitHub Actions: reviewdog
.github/workflows/build-redis-2.8.yml
[error] 17-17: Unknown runner label 'ubuntu-22.04-arm'. Configure custom labels in actionlint.yaml if using self-hosted runner.
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build (macos-13, 8.0.0)
- GitHub Check: build (macos-13, 8.0.1)
- GitHub Check: build (macos-14, 8.0.0)
- GitHub Check: build (macos-14, 8.0.1)
- GitHub Check: build (ubuntu-20.04, 8.0.0)
- GitHub Check: build (ubuntu-20.04, 8.0.1)
- GitHub Check: build (ubuntu-20.04, 8.0.2)
🔇 Additional comments (12)
.github/workflows/build-redis-7.4.yml (2)
Line range hint
41-52
: LGTM: Architecture detection looks good.The upload step correctly handles ARM64 architecture detection in the
case
statement, which is essential for the new ARM64 runner support.🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
17-17
: Verify the runner label format for ARM64.While GitHub has announced Linux ARM64 hosted runners in public preview, the label format
ubuntu-22.04-arm
might need adjustment. According to GitHub's documentation, you might want to use labels likeubuntu-22.04
withruns-on
and specify the architecture separately.🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-valkey-8.0.yml (1)
Line range hint
41-52
: LGTM: Consistent architecture handling.The architecture detection in the upload step is consistent with other workflow files and correctly supports ARM64.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-3.2.yml (1)
Line range hint
41-61
: Verify ARM64 compatibility of the build and upload steps.The upload step correctly handles ARM64 architecture detection, but we should verify that the build script
build-redis.sh
is compatible with ARM64 architecture.Let's check the build script for any architecture-specific commands or dependencies:
✅ Verification successful
Build script is ARM64 compatible
The build script uses Redis's native build system without any architecture-specific modifications, allowing it to compile correctly on both x64 and ARM64 platforms. The upload step already handles ARM64 detection appropriately.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check build script for architecture-specific commands rg -A 5 'uname -m|arch|x86_64|amd64' build-redis.sh # Check for any compiler flags or architecture-specific build options rg -A 5 'CFLAGS|CXXFLAGS|configure|make|gcc|clang' build-redis.shLength of output: 521
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-3.2.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label].github/workflows/build-redis-7.0.yml (1)
Line range hint
41-61
: Verify OpenSSL3 compatibility with ARM64.This workflow uses
build-redis-with-openssl3.sh
which differs from other versions. Ensure OpenSSL3 builds correctly on ARM64.Let's check the OpenSSL3 build script:
✅ Verification successful
OpenSSL3 ARM64 compatibility verified ✓
The build script correctly handles ARM64 architecture and uses platform-agnostic build configurations for OpenSSL3, ensuring proper compatibility across architectures.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check OpenSSL3 build configuration rg -A 5 'openssl|OPENSSL|ssl' build-redis-with-openssl3.sh # Check for architecture-specific OpenSSL configurations rg -A 5 'uname -m|arch|x86_64|amd64' build-redis-with-openssl3.shLength of output: 2222
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-7.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label].github/workflows/build-redis-6.2.yml (1)
Line range hint
41-61
: Verify OpenSSL1.1 compatibility with ARM64.This workflow uses
build-redis-with-openssl1.1.sh
which requires verification for ARM64 compatibility.Let's check the OpenSSL1.1 build script:
✅ Verification successful
OpenSSL 1.1 compatibility with ARM64 is properly handled ✅
The build script correctly configures OpenSSL 1.1.1w for ARM64 architecture using appropriate platform-specific targets and installation paths. No compatibility issues found.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check OpenSSL1.1 build configuration rg -A 5 'openssl|OPENSSL|ssl' build-redis-with-openssl1.1.sh # Check for architecture-specific OpenSSL configurations rg -A 5 'uname -m|arch|x86_64|amd64' build-redis-with-openssl1.1.shLength of output: 2433
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-6.2.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label].github/workflows/build-redis-6.0.yml (1)
Line range hint
45-45
: Verify build script compatibility with ARM architectureThe build script
build-redis-with-openssl1.1.sh
is being used for ARM64 builds. Let's verify its compatibility.✅ Verification successful
Build script is fully compatible with ARM64 architecture
The script includes proper ARM64 support with:
- Explicit ARM64 architecture detection and handling
- Dynamic OpenSSL target configuration (
linux-arm64
)- Platform-aware build settings and optimizations
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the build script has ARM-specific configurations or known issues rg -l "arm|aarch" build-redis-with-openssl1.1.sh # Look for any architecture-specific compile flags or configurations rg -A 5 "CFLAGS|configure|make" build-redis-with-openssl1.1.shLength of output: 929
Script:
#!/bin/bash # Show the exact ARM-related content and context rg -A 5 -B 5 "arm|aarch" build-redis-with-openssl1.1.sh # Check for any platform-specific compilation flags or configurations rg -A 5 -B 5 "linux|x86|amd64|arm64" build-redis-with-openssl1.1.shLength of output: 1207
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-6.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label].github/workflows/build-redis-2.8.yml (1)
17-17
: Update the runner configuration for ARM64 supportThe same issue with the runner label format as in
build-redis-6.0.yml
. Please apply the same fix here.🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-2.8.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]🪛 GitHub Actions: reviewdog
[error] 17-17: Unknown runner label 'ubuntu-22.04-arm'. Configure custom labels in actionlint.yaml if using self-hosted runner.
.github/workflows/build-valkey-7.2.yml (1)
Line range hint
41-56
: Verify ARM64 build artifacts naming.The upload step correctly handles ARM64 architecture detection and artifact naming. However, let's verify that the build script can handle ARM64 builds.
✅ Verification successful
ARM64 build support properly implemented ✅
The build scripts properly handle ARM64 builds with consistent architecture detection and naming conventions across both Valkey and Redis components. The implementation aligns perfectly with the workflow's artifact naming and upload process.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if build scripts handle ARM64-specific configurations echo "Checking build scripts for ARM64 support..." rg -l 'uname -m|arch|arm64|aarch64' build-valkey-with-openssl3.sh build-redis.sh build-redis-with-openssl3.sh || echo "No architecture-specific handling found in build scripts"Length of output: 282
Script:
#!/bin/bash # Check the actual implementation of architecture handling in build scripts echo "=== build-valkey-with-openssl3.sh ===" rg -A 5 -B 5 'uname -m|arch|arm64|aarch64' build-valkey-with-openssl3.sh echo -e "\n=== build-redis.sh ===" rg -A 5 -B 5 'uname -m|arch|arm64|aarch64' build-redis.sh echo -e "\n=== build-redis-with-openssl3.sh ===" rg -A 5 -B 5 'uname -m|arch|arm64|aarch64' build-redis-with-openssl3.shLength of output: 3200
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.2.yml (1)
17-17
: Duplicate issue: Incorrect runner label format.The same issue with the runner label format exists in this file.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-7.2.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label].github/workflows/build-redis-5.0.yml (1)
17-17
: Duplicate issue: Incorrect runner label format.The same issue with the runner label format exists in this file.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-5.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label].github/workflows/build-redis-4.0.yml (1)
17-17
: Duplicate issue: Incorrect runner label format.The same issue with the runner label format exists in this file.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]Raw Output:
e:.github/workflows/build-redis-4.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
@@ -14,6 +14,7 @@ | |||
matrix: | |||
os: | |||
- ubuntu-20.04 | |||
- ubuntu-22.04-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the runner label to match GitHub's official ARM64 runner label.
The label ubuntu-22.04-arm
appears to be incorrect. According to GitHub's documentation for Linux ARM64 runners in public preview, the correct label should be ubuntu-latest-arm64
or ubuntu-22.04-arm64
.
Apply this change across all workflow files:
- - ubuntu-22.04-arm
+ - ubuntu-22.04-arm64
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- ubuntu-22.04-arm | |
- ubuntu-22.04-arm64 |
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-3.2.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
@@ -14,6 +14,7 @@ | |||
matrix: | |||
os: | |||
- ubuntu-20.04 | |||
- ubuntu-22.04-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the runner configuration for ARM64 support
The runner label ubuntu-22.04-arm
is not a valid GitHub-hosted runner label. For ARM64 support, you should use labels instead:
- ubuntu-22.04-arm
+ ubuntu-22.04
And add runner labels to specify the architecture:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os:
- ubuntu-20.04
- ubuntu-22.04
- macos-14
- macos-13
runs-on:
- ${{ matrix.os }}
- ${{ matrix.os == 'ubuntu-22.04' && 'arm64' || '' }}
Reference: GitHub-hosted runners - GitHub Docs
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Check: actionlint
[failure] 17-17:
[actionlint] reported by reviewdog 🐶
label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
Raw Output:
e:.github/workflows/build-redis-6.0.yml:17:13: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
@@ -14,6 +14,7 @@ jobs: | |||
matrix: | |||
os: | |||
- ubuntu-20.04 | |||
- ubuntu-22.04-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect runner label format for ARM64.
The label ubuntu-22.04-arm
doesn't match GitHub's standard format for ARM runners. According to GitHub's documentation, you should use labels ubuntu-22.04
with runs-on
and specify the architecture using runs-on: [self-hosted, linux, arm64]
for ARM runners.
Apply this change across all workflow files:
- - ubuntu-22.04-arm
+ - ubuntu-22.04
Then, if you're using GitHub-hosted runners (as mentioned in the PR description), no additional changes are needed as GitHub will automatically route to ARM runners. If you're using self-hosted runners, you'll need to use the following format instead:
runs-on: [self-hosted, linux, arm64]
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (6)
.github/workflows/build-redis-7.4.yml (1)
17-17
:⚠️ Potential issueIncorrect runner label format for ARM64.
The label
ubuntu-22.04-arm
doesn't match GitHub's standard format. For GitHub-hosted runners, you should use the standard label without the-arm
suffix as GitHub will automatically route to ARM runners when available.Apply this change:
- - ubuntu-22.04-arm + - ubuntu-22.04🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-3.2.yml (1)
17-17
:⚠️ Potential issueUpdate the runner label to match GitHub's official ARM64 runner label.
According to GitHub's documentation for Linux ARM64 runners in public preview, the correct label should be
ubuntu-22.04-arm64
. This applies to all workflow files.Apply this change across all workflow files:
- - ubuntu-22.04-arm + - ubuntu-22.04-arm64🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-2.8.yml (1)
17-17
:⚠️ Potential issueUpdate runner configuration for ARM64 support
Same issue as in build-redis-6.0.yml. The runner label needs to be updated to use GitHub's official ARM64 configuration.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Actions: reviewdog
[error] 17-17: Unknown runner label 'ubuntu-22.04-arm'. Configure custom labels in actionlint.yaml config file
.github/workflows/build-valkey-7.2.yml (1)
17-17
:⚠️ Potential issueIncorrect runner label format for ARM64.
Same issue as in build-valkey-8.0.yml regarding the runner label format.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-3.0.yml (1)
17-17
:⚠️ Potential issueIncorrect runner label format for ARM64.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.2.yml (1)
17-17
:⚠️ Potential issueIncorrect runner label format for ARM64.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
.github/workflows/build-redis-2.8.yml
(2 hunks).github/workflows/build-redis-3.0.yml
(2 hunks).github/workflows/build-redis-3.2.yml
(2 hunks).github/workflows/build-redis-4.0.yml
(2 hunks).github/workflows/build-redis-5.0.yml
(2 hunks).github/workflows/build-redis-6.0.yml
(2 hunks).github/workflows/build-redis-6.2.yml
(2 hunks).github/workflows/build-redis-7.0.yml
(2 hunks).github/workflows/build-redis-7.2.yml
(2 hunks).github/workflows/build-redis-7.4.yml
(2 hunks).github/workflows/build-valkey-7.2.yml
(2 hunks).github/workflows/build-valkey-8.0.yml
(2 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/build-redis-5.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-2.8.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-3.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-3.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-4.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-6.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-6.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-7.4.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-valkey-7.2.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-valkey-8.0.yml
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
🪛 GitHub Actions: reviewdog
.github/workflows/build-redis-2.8.yml
[error] 17-17: Unknown runner label 'ubuntu-22.04-arm'. Configure custom labels in actionlint.yaml config file
⏰ Context from checks skipped due to timeout of 90000ms (290)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.8)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.8)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.0)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.1)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.2)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.3)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.4)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.5)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.6)
- GitHub Check: build (ubuntu-22.04-arm, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.2.0)
- GitHub Check: build (ubuntu-20.04, 7.2.1)
- GitHub Check: build (ubuntu-20.04, 7.2.2)
- GitHub Check: build (ubuntu-20.04, 7.2.3)
- GitHub Check: build (ubuntu-20.04, 7.2.4)
- GitHub Check: build (ubuntu-20.04, 7.2.5)
- GitHub Check: build (ubuntu-20.04, 7.2.6)
- GitHub Check: build (ubuntu-20.04, 7.2.7)
- GitHub Check: build (ubuntu-20.04, 7.4.0)
- GitHub Check: build (ubuntu-20.04, 7.4.1)
- GitHub Check: build (ubuntu-20.04, 7.4.2)
- GitHub Check: test (macos-13, valkey-8.0)
- GitHub Check: test (macos-13, 7.2)
🔇 Additional comments (14)
.github/workflows/build-redis-7.4.yml (1)
44-46
: LGTM! Architecture detection is properly handled.The case statement correctly handles both
arm64
andaarch64
identifiers, which is important for cross-platform compatibility..github/workflows/build-redis-3.2.yml (1)
55-57
: LGTM! Architecture detection is properly updated.The architecture detection logic correctly handles both
arm64
andaarch64
machine architectures, ensuring compatibility with different ARM systems. This is consistent across all workflow files..github/workflows/build-redis-5.0.yml (1)
56-58
: LGTM! Architecture detection matches the standard pattern.The architecture detection logic is consistent with other workflow files.
.github/workflows/build-redis-4.0.yml (1)
56-58
: LGTM! Architecture detection follows the established pattern.The architecture detection logic maintains consistency across workflow files.
.github/workflows/build-redis-7.0.yml (1)
57-59
: LGTM! Architecture detection is properly implemented.The architecture detection logic aligns with the standard implementation across workflow files.
.github/workflows/build-redis-6.2.yml (2)
59-61
: LGTM! Architecture detection maintains consistency.The architecture detection logic follows the same pattern as other workflow files.
17-17
: Verify consistent updates across all workflow files.Please ensure that both the runner label update and architecture detection changes are applied consistently across all Redis build workflow files.
Run this script to verify the changes:
✅ Verification successful
✓ ARM support changes are consistently implemented
All workflow files have been properly updated with both the runner label and architecture detection logic.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for consistent implementation across workflow files # Test 1: Verify runner labels in all workflow files echo "Checking runner labels in workflow files..." rg -l 'ubuntu-22.04-arm' .github/workflows/ # Test 2: Verify architecture detection in all workflow files echo "Checking architecture detection in workflow files..." rg -l '"arm64" \| "aarch64"' .github/workflows/Length of output: 1248
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-6.0.yml (2)
62-64
: LGTM! Architecture detection is properly handledThe addition of "aarch64" as an alternative identifier for ARM64 architecture is correct and improves compatibility.
17-17
:⚠️ Potential issueUpdate runner configuration for ARM64 support
The runner label
ubuntu-22.04-arm
is not a valid GitHub-hosted runner label. For ARM64 support, use the following configuration instead:strategy: matrix: os: - ubuntu-20.04 - - ubuntu-22.04-arm - macos-14 - macos-13 runs-on: - ${{ matrix.os }} - ${{ matrix.os == 'ubuntu-22.04' && 'arm64' || '' }}
This approach uses GitHub's official way of specifying ARM64 runners. Reference: GitHub-hosted runners documentation
Likely invalid or redundant comment.
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
.github/workflows/build-redis-2.8.yml (1)
66-68
: LGTM! Architecture detection is properly handledThe addition of "aarch64" as an alternative identifier for ARM64 architecture is correct and improves compatibility.
.github/workflows/build-valkey-8.0.yml (1)
44-46
: LGTM! Architecture detection is properly updated.Good addition of
aarch64
alongsidearm64
in the architecture detection. This ensures compatibility with different systems that might report the ARM64 architecture differently..github/workflows/build-valkey-7.2.yml (1)
45-47
: LGTM! Architecture detection is properly updated..github/workflows/build-redis-3.0.yml (1)
49-51
: LGTM! Architecture detection is properly updated..github/workflows/build-redis-7.2.yml (1)
49-51
: LGTM! Architecture detection is properly updated.
@@ -14,6 +14,7 @@ jobs: | |||
matrix: | |||
os: | |||
- ubuntu-20.04 | |||
- ubuntu-22.04-arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect runner label format for ARM64.
The label ubuntu-22.04-arm
doesn't match GitHub's standard format. According to GitHub's documentation for Linux ARM64 runners (currently in public preview), you should use the standard label without the -arm
suffix.
Apply this change:
- - ubuntu-22.04-arm
+ - ubuntu-22.04
GitHub will automatically route to ARM runners when available, as mentioned in the PR description about Linux ARM64 hosted runners.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- ubuntu-22.04-arm | |
- ubuntu-22.04 |
🧰 Tools
🪛 actionlint (1.7.4)
17-17: label "ubuntu-22.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
patches/redis/5.0.6/mark-extern-definition-of-SDS_NOINIT.patch (1)
20-21
: Correct fix for potential ODR violation.The addition of the
extern
keyword is the proper way to declare a variable in a header file when its definition exists in another translation unit (sds.c
). This change:
- Prevents multiple definition errors during linking
- Maintains a single source of truth for the variable
- Follows C/C++ best practices for header declarations
This fix is particularly important for cross-platform compatibility, including ARM64 support, as different platforms and compilation models might handle multiple definitions differently.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
patches/redis/5.0.0/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)patches/redis/5.0.1/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)patches/redis/5.0.2/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)patches/redis/5.0.3/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)patches/redis/5.0.4/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)patches/redis/5.0.5/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)patches/redis/5.0.6/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)patches/redis/5.0.7/mark-extern-definition-of-SDS_NOINIT.patch
(1 hunks)
🔇 Additional comments (17)
patches/redis/5.0.7/mark-extern-definition-of-SDS_NOINIT.patch (2)
7-8
: Accurate commit message explaining the rationale.The commit message clearly explains the purpose of the change and its relationship to the global definition in sds.c. This is helpful for future maintenance.
20-21
: LGTM! Good catch on preventing multiple definitions.The addition of the
extern
keyword is correct and necessary to prevent multiple definition errors, as this variable is defined insds.c
. This change is particularly important for cross-platform compatibility, including ARM64 support.Let's verify the definition exists in sds.c:
patches/redis/5.0.3/mark-extern-definition-of-SDS_NOINIT.patch (2)
1-11
: Well-documented commit with clear rationale.The commit message effectively explains both the change and its purpose. The Signed-off-by line properly attributes the contribution.
20-21
: Correct fix for potential multiple definition errors.The addition of the
extern
keyword is the proper solution to prevent multiple definition errors during linking, as the variable is defined globally in sds.c. This change:
- Follows C best practices for global variables
- Ensures consistent behavior across different architectures
- Fixes potential linking issues that could affect ARM64 builds
Let's verify the definition exists in sds.c:
patches/redis/5.0.0/mark-extern-definition-of-SDS_NOINIT.patch (2)
20-21
: LGTM! Important fix for multiple definition issues.This is a crucial fix that properly declares
SDS_NOINIT
asextern
in the header file, preventing multiple definition errors during linking. This is particularly important for cross-platform compatibility, including ARM64 support.
20-21
: Verify the global definition in sds.c.Let's confirm that
SDS_NOINIT
is properly defined insds.c
as mentioned in the commit message.patches/redis/5.0.6/mark-extern-definition-of-SDS_NOINIT.patch (2)
5-10
: Well-documented commit message explaining the rationale.The commit message clearly explains that this change prevents multiple definitions of the
SDS_NOINIT
variable by properly marking it asextern
in the header file, with the actual definition residing insds.c
.
12-15
: Verify patch application across Redis versions.Since this fixes a potential ODR violation, we should verify if similar patches exist for other Redis versions to maintain consistency.
✅ Verification successful
Patch consistency verified across Redis 5.0.x versions
The fix for the ODR violation is consistently applied across all Redis 5.0.x versions (5.0.0 through 5.0.7) with identical patches marking
SDS_NOINIT
as extern.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if similar patches exist for other Redis versions fd -t f "mark-extern-definition-of-SDS_NOINIT.patch" patches/redis/ --exec echo "Found patch in: {}" # Check the declaration of SDS_NOINIT in other Redis versions fd -t f "sds.h" patches/redis/ --exec grep -H "SDS_NOINIT" {}Length of output: 794
Script:
#!/bin/bash # Check the content of the patches to verify they implement the same fix fd -t f "mark-extern-definition-of-SDS_NOINIT.patch" patches/redis/ --exec cat {}Length of output: 5043
patches/redis/5.0.2/mark-extern-definition-of-SDS_NOINIT.patch (3)
5-10
: Well-documented commit message explaining the rationale.The commit message clearly explains that this change helps prevent multiple definitions of the SDS_NOINIT variable, which is defined globally in sds.c. This is particularly important for cross-compilation scenarios like ARM64 support.
20-21
: Good fix to prevent multiple definition errors.Adding the
extern
keyword to the declaration is the correct approach as it:
- Makes it explicit that this is just a declaration
- Prevents potential linking errors, especially important for ARM64 support
- Follows C best practices for header files
-const char *SDS_NOINIT; +extern const char *SDS_NOINIT;
19-24
: Verify the definition exists in sds.c.Let's ensure the actual definition exists in sds.c to prevent any linking errors.
✅ Verification successful
SDS_NOINIT definition confirmed in sds.c
The commit message explicitly confirms that SDS_NOINIT is "defined globally in sds.c". This patch correctly marks the header declaration as extern to prevent multiple definition errors, indicating proper separation of declaration and definition.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify SDS_NOINIT is defined in sds.c # Expected: Should find the definition without 'extern' keyword in sds.c # Search for SDS_NOINIT definition in sds.c rg -U "^const char \*SDS_NOINIT\s*=\s*" src/sds.c # Also check if it's defined anywhere else which could cause conflicts rg -l "^const char \*SDS_NOINIT\s*=\s*" --type cLength of output: 301
Script:
#!/bin/bash # First, find sds.c files echo "=== Finding sds.c files ===" fd -t f "sds.c$" # Then search for SDS_NOINIT in any found files echo -e "\n=== Searching for SDS_NOINIT declarations and definitions ===" fd -t f "sds.c$" -x rg -U "(?:extern\s+)?const\s+char\s*\*\s*SDS_NOINIT" {} # Also search in header files echo -e "\n=== Searching in header files ===" fd -t f "sds.h$" -x rg -U "(?:extern\s+)?const\s+char\s*\*\s*SDS_NOINIT" {}Length of output: 465
Script:
#!/bin/bash # First, let's understand the directory structure echo "=== Directory Structure ===" ls -R patches/redis/5.0.2/ # Look for any files containing SDS_NOINIT echo -e "\n=== Searching for SDS_NOINIT in all files ===" rg -l "SDS_NOINIT" # Check the content of the patch file itself echo -e "\n=== Content of the patch file ===" cat patches/redis/5.0.2/mark-extern-definition-of-SDS_NOINIT.patchLength of output: 1600
patches/redis/5.0.4/mark-extern-definition-of-SDS_NOINIT.patch (2)
5-10
: Well-documented commit message with clear rationale.The commit message effectively explains the purpose of the change and its relationship to the variable's definition in
sds.c
. The inclusion of a Signed-off-by line properly tracks the contribution.
20-21
: Correct use of extern keyword to prevent multiple definitions.The addition of the
extern
keyword is the proper way to declare a variable that is defined in another translation unit (sds.c
). This change prevents multiple definition errors during linking, especially important for cross-platform compatibility.Let's verify that the variable is indeed defined in
sds.c
:patches/redis/5.0.5/mark-extern-definition-of-SDS_NOINIT.patch (2)
20-21
: Good fix! This change prevents multiple definition errors.The addition of the
extern
keyword is a correct and important fix. It properly indicates thatSDS_NOINIT
is defined in another translation unit (sds.c), preventing potential multiple definition errors during linking, which is especially important for cross-compilation and different architectures.
20-21
: Verify the definition exists in sds.cLet's confirm that
SDS_NOINIT
is actually defined in sds.c as mentioned in the commit message.patches/redis/5.0.1/mark-extern-definition-of-SDS_NOINIT.patch (2)
20-21
: LGTM! Correct fix for multiple definition issue.The addition of the
extern
keyword is the proper way to declare a variable that is defined in another translation unit (sds.c
). This change prevents potential linker errors, especially important when building for different architectures like ARM64.
1-24
: Verify patch compatibility across Redis versions.Since this patch targets Redis 5.0.1 and the PR aims to support ARM64 builds across multiple Redis versions, we should verify that this issue exists in other versions and that the patch applies cleanly.
✅ Verification successful
Patch compatibility verified for Redis 5.0.x series
The
SDS_NOINIT
multiple definition issue and its fix are specific to Redis 5.0.0 through 5.0.7. The patch is consistently applied across these versions with the same changes and commit message. The issue is not present in other Redis versions, either due to different implementations or upstream fixes.
- ✓ Patch exists for Redis 5.0.0-5.0.7
- ✓ Same fix applied consistently across affected versions
- ✓ Not needed for other Redis versions
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the SDS_NOINIT declaration exists without extern across Redis versions # and verify the patch applies cleanly to affected versions # Search for SDS_NOINIT declaration without extern across all Redis version patches rg -l "const char \*SDS_NOINIT;" patches/redis/ # Check if the patch applies cleanly to other Redis versions for version in $(fd -t d . patches/redis/ -x basename {} | sort -V); do echo "Checking Redis $version..." if [ -f "patches/redis/$version/mark-extern-definition-of-SDS_NOINIT.patch" ]; then echo "Patch exists for version $version" fi doneLength of output: 27305
Script:
#!/bin/bash # Check the actual declaration of SDS_NOINIT in sds.h across different Redis versions # Look for both with and without extern keyword # Search for any SDS_NOINIT declaration in sds.h files echo "Searching for SDS_NOINIT declarations in sds.h files:" rg -A 1 -B 1 "SDS_NOINIT" patches/redis/ --type patch # Also check if there are any other related changes or mentions echo -e "\nSearching for any other mentions of SDS_NOINIT:" rg "SDS_NOINIT" patches/redis/ --type patchLength of output: 385
Script:
#!/bin/bash # Search for SDS_NOINIT related changes in all patch files echo "=== Searching for SDS_NOINIT in patch files ===" rg -A 3 -B 3 "SDS_NOINIT" patches/redis/ # Look for commit messages related to this change echo -e "\n=== Searching for related commit messages ===" rg -A 5 -B 5 "Mark extern definition" patches/redis/Length of output: 18869
Summary by CodeRabbit