-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump eslint v9 #962
bump eslint v9 #962
Conversation
WalkthroughThe modifications enhance the GitHub Actions workflow for linting and type-checking JavaScript and TypeScript code. Job roles were clarified through renaming, and additional steps were introduced for better Node.js dependency management. A new ESLint configuration file was added, integrating TypeScript support. The Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (4)
- .github/workflows/reviewdog.yml (1 hunks)
- eslint.config.mjs (1 hunks)
- package.json (1 hunks)
- src/installer.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- eslint.config.mjs
- src/installer.ts
Additional comments not posted (6)
.github/workflows/reviewdog.yml (2)
7-11
: LGTM!The
actionlint
job setup appears correct for linting GitHub Actions workflows.
13-27
: Well-structured ESLint job configuration.The
eslint
job is well-configured with Node.js setup, npm caching, and appropriate ESLint flags for TypeScript files.package.json (4)
37-37
: Appropriate addition of@eslint/js
.The addition of
@eslint/js
aligns with the use of official ESLint configurations and rules.
38-38
: Enhancement with@types/eslint__js
.The addition of
@types/eslint__js
enhances TypeScript support for ESLint.
43-43
: Update to ESLint version^9.9.0
.The update to ESLint introduces new rules and enhancements, aligning with modern standards.
48-48
: Improved TypeScript integration withtypescript-eslint
.The addition of
typescript-eslint
improves TypeScript integration with ESLint, enhancing code quality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/installer.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/installer.ts
Summary by CodeRabbit
New Features
Bug Fixes
Chores