feat(composables): new total price property for useCartItem composable #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
patzick
requested changes
Apr 25, 2023
Comment on lines
118
to
119
| await removeCartItem(cartItem.value.id, apiInstance); | ||
| refreshCart(); |
There was a problem hiding this comment.
cart operation is returning cart, what would you say to do something like this?
Suggested change
| await removeCartItem(cartItem.value.id, apiInstance); | |
| refreshCart(); | |
| const newCart = await removeCartItem(cartItem.value.id, apiInstance); | |
| await refreshCart(newCart); |
and then in useCart
async function refreshCart(newCart?: Cart): Promise<Cart> {
if (newCart) {
_storeCart.value = newCart;
return newCart;
}
const result = await getCart(apiInstance);
_storeCart.value = result;
return result;
}so we can skip additional server request?
There was a problem hiding this comment.
good improvement. I will do 🚀
| } | ||
|
|
||
| /** | ||
| * @deprecated Method is not used anymore and the case should be solved on project level instead due to performance reasons. |
There was a problem hiding this comment.
let's add patch changeset entry for that
| import { getSmallestThumbnailUrl } from "@shopware-pwa/helpers-next"; | ||
| import { LineItem } from "@shopware-pwa/types"; | ||
| import { getSmallestThumbnailUrl } from "@shopware-pwa/helpers-next"; | ||
| import { LineItem } from "@shopware-pwa/types"; |
There was a problem hiding this comment.
script setup components have formatting from the first line without tabs, can you make sure you formatted this file? :)
There was a problem hiding this comment.
idk why but I had a prettier as default formatter. Switched back to volar and works good as expected :)
Co-authored-by: Patryk Tomczyk <[email protected]>
patzick
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #157
Type of change
Screenshots (if applicable)
Additional context