Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composables): proper currency and price context on SSR #179

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Apr 27, 2023

Description

closes #164

Fixes hydration error causing prices to be visible without currency

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if applicable)

Additional context

@patzick patzick requested a review from mkucmus April 27, 2023 08:39
@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 8:42am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 8:42am

@patzick patzick merged commit bb64070 into main Apr 27, 2023
@patzick patzick deleted the fix/currency-and-locale-context branch April 27, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Hydration on shared price
2 participants