Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add payment description and logo #241

Merged
merged 1 commit into from
Jun 6, 2023
Merged

feat: add payment description and logo #241

merged 1 commit into from
Jun 6, 2023

Conversation

mdanilowicz
Copy link
Collaborator

Description

closes #240

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if applicable)

Additional context

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 11:32am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 11:32am

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I like it!

question for the future: should we maybe encourage people to use our helpers for all media/images even if it's a demo template 🤔

@patzick patzick merged commit 51007dc into main Jun 6, 2023
@patzick patzick deleted the feat/GH-240 branch June 6, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Logo and description for payment methods
3 participants