Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: typecheck on linting #303

Merged
merged 6 commits into from
Jul 6, 2023
Merged

feat: typecheck on linting #303

merged 6 commits into from
Jul 6, 2023

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jul 6, 2023

Description

Our linting process was not doing typechecking, which allowed some typing errors to come into application.

  • every package now runs typecheck after lint process (or with build), so GH action will be more restrictive
  • eslint rules are upgraded, so after lint 3 filed from cms-base are no longer showing up
  • build processes of vue3-plugin and types are switched to unbuild for consistency

@vercel
Copy link

vercel bot commented Jul 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 8:12am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 8:12am

@patzick patzick marked this pull request as draft July 6, 2023 07:02
@patzick patzick marked this pull request as ready for review July 6, 2023 08:00
mkucmus
mkucmus requested changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks huge, but still works great, or better ;) one question regarding vite in typer package, because you've changed build tool to unbuild

@patzick patzick merged commit aeb639a into main Jul 6, 2023
@patzick patzick deleted the feat/typecheck-on-linting branch July 6, 2023 10:16
mkucmus pushed a commit that referenced this pull request Jul 6, 2023
@patzick @mkucmus
feat: typecheck on linting (#303)
ad7e96c
mkucmus pushed a commit that referenced this pull request Jul 7, 2023
@patzick @mkucmus
feat: typecheck on linting (#303)
c7e5cd4
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkucmus mkucmus mkucmus approved these changes

@mdanilowicz mdanilowicz Awaiting requested review from mdanilowicz

@BrocksiNet BrocksiNet Awaiting requested review from BrocksiNet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patzick @mkucmus