Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vue-demo): add private shopwareEndpoint #325

Merged
merged 6 commits into from
Jul 21, 2023
Merged

feat(vue-demo): add private shopwareEndpoint #325

merged 6 commits into from
Jul 21, 2023

Conversation

mdanilowicz
Copy link
Collaborator

Description

closes #323

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if applicable)

Additional context

@vercel
Copy link

vercel bot commented Jul 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Jul 21, 2023 8:14am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Jul 21, 2023 8:14am

patzick
patzick requested changes Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we need some documentation for this config - how and when to use it 📖

patzick
patzick approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@patzick patzick merged commit faf28ca into main Jul 21, 2023
@patzick patzick deleted the feat/GH-323 branch July 21, 2023 08:33
@github-actions github-actions bot mentioned this pull request Jul 21, 2023
Merged
@jhony1104 jhony1104 mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrocksiNet BrocksiNet BrocksiNet left review comments

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nuxt 3: Different private & public shopwareEndpoint runtime configs
3 participants
@mdanilowicz @BrocksiNet @patzick