Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve setup support #404

Merged
merged 4 commits into from
Oct 23, 2023
Merged

feat: improve setup support #404

merged 4 commits into from
Oct 23, 2023

Conversation

BrocksiNet
Copy link
Collaborator

Description

  • Extends the error.vue template in demo store when in development mode
  • Returns an error message in the terminal when a connection to API is not possible
  • Add a new useConnectionTest composable
  • Sorting from A to Z for composables in nuxt module
  • Improved code a bit for better readability
  • Adding two new entries for troubleshooting page

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots (if applicable)

image
image

@vercel
Copy link

vercel bot commented Sep 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontends-demo ✅ Ready (Inspect) Visit Preview Oct 23, 2023 7:58am
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview Oct 23, 2023 7:58am

@BrocksiNet BrocksiNet requested a review from mkucmus September 25, 2023 12:35
@BrocksiNet
Copy link
Collaborator Author

Hmmm maybe also a bit connected with #276 🤔

mkucmus
mkucmus requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the functional programming approach in a plugin 👍🏼

See the comments, especially the ssg related.

@BrocksiNet BrocksiNet requested a review from mkucmus October 4, 2023 12:11
mkucmus
mkucmus approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼

@BrocksiNet BrocksiNet requested a review from patzick October 13, 2023 14:06
patzick
patzick approved these changes Oct 23, 2023
View reviewed changes
@patzick patzick merged commit f356675 into main Oct 23, 2023
@patzick patzick deleted the feat/improve-setup-support branch October 23, 2023 08:08
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkucmus mkucmus mkucmus approved these changes

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrocksiNet @mkucmus @patzick