Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(templates): Production build example for vue-demo-store #90

Merged
merged 2 commits into from
Mar 29, 2023
Merged

feat(templates): Production build example for vue-demo-store #90

merged 2 commits into from
Mar 29, 2023

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Mar 28, 2023 •
edited
Loading

closes: #77

@vercel
Copy link

vercel bot commented Mar 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
frontends-demo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 7:53PM (UTC)
shopware-frontends-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 7:53PM (UTC)

@mkucmus
Copy link
Collaborator Author

mkucmus commented Mar 28, 2023

Hey @patzick, I'm also thinking of changing the default production preset from vercel to node-server to be more local friendly:
https://github.com/shopware/frontends/pull/90/files#diff-037c0c63ce96c99947956155933fa492ca0022f8f2f42aeb5245de8528a41053R2

in this case we could simplify the way how the template is built (we say: run build and start and that's it) without changing a preset.
For our purposes we could change the .env.production or env itself in the build time to be a vercel.

@mkucmus mkucmus requested a review from patzick March 28, 2023 20:29
patzick
patzick approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!
Let's create another PR on top to change the defaultNITRO_PRESET, then we'll set vercel on environment variables only for preview building and CI will ensure us whole thing is working properly :)

@patzick patzick mentioned this pull request Mar 29, 2023
Closed
@patzick patzick merged commit d394ca0 into main Mar 29, 2023
@patzick patzick deleted the feat/production-build-for-template branch March 29, 2023 05:58
nwtben pushed a commit to nwtben/frontends that referenced this pull request Jul 24, 2023
@aleksadev2
Merged in feature/TN-31-my-account-page (pull request shopware#90)
aacf699 
TN-31: updated comments for account page, v0615

Approved-by: Radu Istoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue-demo-store locally in production mode
2 participants
@mkucmus @patzick