Fix issues a11y of tooltip #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Lucsy3012
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR improves the a11y of the tooltip. The triangle of the tooltip gets no longer read out loud by the screenreader but the content of the tooltip does.
Why?
Announcing the triangle of the tooltip does not add any value to a screen reader user, it actually worsens the UX.
How?
I've added an
aria-hiddenattribute to the triangle.Testing?
Checkout the branch preview, go to any
mt-tooltipstory. Activate your screenreader and focus the button. Now it should announce the content of the button, pause for a short amount of time and then announce the content of the tooltip.