ci: enable corepack in npm preview build #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The actions/setup-node@v4 action fails because it cannot correctly use corepack. To fix that I implemented workaround. It installs corepack via npm and then enables it. We cannot remove it, because pkg.pr.new needs corepack in order to work. See: actions/setup-node#1222 (comment)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lucsy3012
approved these changes
Feb 20, 2025
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
@shopware-ag/meteor-icon-kit
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes the failing preview build job by installing corepack via npm
Why?
The actions/setup-node@v4 action fails because it cannot correctly use corepack.
To fix that I implemented workaround. It installs corepack via npm and then enables it.
We cannot remove it, because pkg.pr.new needs corepack in order to work.
How?
The job now installs
corepackvia npm and then enables it.Testing?
In order to test that, we need to create a preview build. To start that preview build
one person needs to approve this PR.
Anything Else?
See: actions/setup-node#1222 (comment)