Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set fetch depth to 0 for main ci #54

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

bryanoltman
Copy link

@bryanoltman bryanoltman commented May 22, 2024

Same as #53, but for the main CI workflow.

Note: Ubuntu and Windows will still fail to due:

Run dart ./dev/bots/test.dart
▌19:43:39▐ STARTING ANALYSIS
▌19:43:39▐ SHARD=add_to_app_life_cycle_tests
╔═╡ERROR #1╞════════════════════════════════════════════════════════════════════
║ UNEXPECTED ERROR!
║ Exception: Only iOS has add-to-add lifecycle tests at this time.
║ #0      addToAppLifeCycleRunner (file:///home/runner/work/flutter/flutter/dev/bots/suite_runners/run_add_to_app_life_cycle_tests.dart:21:5)
║ #1      main.<anonymous closure> (file:///home/runner/work/flutter/flutter/dev/bots/test.dart:233:44)
║ #2      _runFromList (file:///home/runner/work/flutter/flutter/dev/bots/test.dart:2043:32)
║ #3      selectShard (file:///home/runner/work/flutter/flutter/dev/bots/test.dart:202[8](https://github.com/shorebirdtech/flutter/actions/runs/9197435193/job/25297868422?pr=51#step:5:9):62)
║ #4      main (file:///home/runner/work/flutter/flutter/dev/bots/test.dart:232:11)
║ #5      _delayEntrypointInvocation.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:2[9](https://github.com/shorebirdtech/flutter/actions/runs/9197435193/job/25297868422?pr=51#step:5:10)5:33)
║ #6      _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)
║ 
║ The test.dart script should be corrected to catch this error and call foundError().
║ Some tests are likely to have been skipped.
╚═══════════════════════════════════════════════════════════════════════════════

Mac is still failing, but it seems to be getting further

@bryanoltman bryanoltman merged commit c503e2f into shorebird/dev May 23, 2024
1 of 4 checks passed
@bryanoltman bryanoltman deleted the bo/fix-main-ci branch May 23, 2024 14:57
bryanoltman added a commit that referenced this pull request May 24, 2024
* set fetch depth to 0 for main ci

* add missing with:
bryanoltman added a commit that referenced this pull request May 28, 2024
* set fetch depth to 0 for main ci

* add missing with:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant