feat: Checks needed disk space before starting install #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanoltman
reviewed
Dec 19, 2024
install.ps1
Outdated
| @@ -64,6 +64,20 @@ Test-GitVersion | |||
|
|
|||
| $force = $args -contains "--force" | |||
|
|
|||
| # Check if there is enough free space | |||
| $requiredSpace = 1100MB # 1100 MiB | |||
There was a problem hiding this comment.
How was this value chosen?
There was a problem hiding this comment.
This was near the smallest amount needed to complete the install of shorebird, including the Flutter cache, and pub packages that are pulled down.
Testing was done on MacOS
hdiutil create -size 1250m -fs HFS+ -volname "TestVolume" test.dmg
hdiutil attach test.dmg
HOME=/Volumes/TestVolume ./install.sh
hdiutil detach /Volumes/TestVolume
install.sh
Outdated
| @@ -94,6 +94,18 @@ if [ $GIT_VERSION_COMPARISON -eq 2 ]; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # Check if there is enough free space | |||
| REQUIRED_SPACE=$((1100 * 1024)) # 1100 MiB in KiB | |||
| FREE_SPACE=$(df -k "$(dirname "$(install_dir)")" | tail -1 | awk '{print $4}') | |||
There was a problem hiding this comment.
This is a really dense line and could stand to be broken up and commented
|
If this is a distraction from what you need to be focused on feel free to close, not that you didn't already have that capability. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit early when their likely will not be enough disk space to install shorebird
Description
--forceAttempt to address #27
Type of Change