Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shorebird_code_push): track support #232

Merged
merged 13 commits into from
Nov 12, 2024
Merged

feat(shorebird_code_push): track support #232

merged 13 commits into from
Nov 12, 2024

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Nov 7, 2024 •
edited by bryanoltman
Loading

Description

Add track support

ScreenRecording_11-08-2024.13-22-20_1.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.79518% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
library/src/c_api/mod.rs 97.91% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

felangel
felangel commented Nov 7, 2024
View reviewed changes
library/src/updater.rs Outdated Show resolved Hide resolved
felangel
felangel commented Nov 7, 2024
View reviewed changes
shorebird_code_push/example/lib/main.dart Outdated
@@ -31,6 +31,7 @@ class _MyHomePageState extends State<MyHomePage> {
late final bool _isUpdaterAvailable;
var _isCheckingForUpdates = false;
Patch? _currentPatch;
UpdateTrack? _currentTrack;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also add a bool to track the initialization state of the track

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"track the initialization state" = hasUpdateTrackBeenSet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the example to provide clearer demonstration of the functionality (see video). This is less representative of how end users will likely want to structure this check, but I think that's maybe a separate example we can provide in a blog post or in our docs.

@bryanoltman bryanoltman marked this pull request as ready for review November 8, 2024 18:35
@bryanoltman bryanoltman mentioned this pull request Nov 8, 2024
Merged
@bryanoltman
Copy link
Contributor

I think this is ready for review. @eseidel and I spoke about adding a version reporting function to the C API, but that probably belongs in a separate PR

@bryanoltman
Copy link
Contributor

Verbal LGTM from @felangel on Discord

@bryanoltman bryanoltman merged commit ee3f5ec into main Nov 12, 2024
6 checks passed
@bryanoltman bryanoltman deleted the feat/support-tracks branch November 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanoltman bryanoltman bryanoltman approved these changes

@eseidel eseidel Awaiting requested review from eseidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felangel @bryanoltman