Mechanism to wake up oscs if amplitude changes #175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #164 we noted that once the noise osc within a Juno voice has hit zero amplitude, subsequent changes to its level will not introduce noise, because the
zero_amp_clock
mechanism has already taken that osc out ofAUDIBLE
status.This change introduces a new
AUDIBLE_SUSPENDED
status for oscillators that have reached zero amplitude. Then, if there are later events that modify the amplitude or envelope generator parameters for that osc, and provided it has not seen a note-off since the last note-on, those changes return it fromAUDIBLE_SUSPENDED
toAUDIBLE
. If, in fact, those parameter changes still leave the output at zero, themax_val
check inrender_osc_wave()
will return it toAUDIBLE_SUSPENDED
within a few frames.