Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esp Tulip for later AMY #156

Closed
bwhitman opened this issue Jan 6, 2024 · 8 comments
Closed

Update esp Tulip for later AMY #156

bwhitman opened this issue Jan 6, 2024 · 8 comments

Comments

@bwhitman
Copy link
Collaborator

bwhitman commented Jan 6, 2024

I broke the esp32s3 build by mistakenly merging in the latest AMY without first fixing up how AMY is instantiated on tulip.

I'll track that work here, I'll need to test on hardware.

For now, if you want to use esp32s3 Tulip, roll back a few commits:

git checkout 793324c
rm .submodules_ok
cd tulip/esp32s3/
idf.py ...

cc @norahqueen

This was referenced Jan 6, 2024
bwhitman added a commit that referenced this issue Jan 6, 2024
@bwhitman
Copy link
Collaborator Author

bwhitman commented Jan 6, 2024

OK, I've committed a fix for this to main, please pull (and rm .submodules_ok), and try to build again. I confirmed that the build completes for me on esp32s3 and tdeck. I have not confirmed Alles/AMY works on boot on Tdeck or bare esp32s3, as I'm away from my hardware right now. Can double check in a day or two!

@JustDr00py
Copy link

I have tested the recent commit on my tdeck, everything compiles and flashes but alles.drums() now plays high pitched tones and sounds broken.

@bwhitman
Copy link
Collaborator Author

bwhitman commented Jan 6, 2024

That could be an older version of alles.py. Can you try to do an idf.py fullclean then flash again?

@bwhitman
Copy link
Collaborator Author

bwhitman commented Jan 7, 2024

Haha nope, I got my T-Deck and hear what you're hearing. Will look into it

@bwhitman
Copy link
Collaborator Author

bwhitman commented Jan 7, 2024

We have two issues, one of which I fixed

(a) we were sending stereo samples to a mono-configured i2s chip on the Tdeck. I fixed that.
(b) Something about the new filter modes in newer AMY make that little speaker go mad. I asked @dpwe to check it out. If you comment out the "bassline" in alles.py you'll hear the drum loop just fine.

I think this is Tdeck only, but I'll test on big Tulip asap.

@JustDr00py
Copy link

thank you again its working now

@norahqueen
Copy link

Got it working on my tdeck, thank you @bwhitman

Can confirm getting the same issue with alles.drums()

@bwhitman
Copy link
Collaborator Author

bwhitman commented Jan 9, 2024

@JustDr00py @norahqueen @dpwe fixed the filter on AMY that was making the T-Deck go wild. Pull up to main and rm .submodules_ok, build again and it should be fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants