This repository has been archived by the owner on Dec 27, 2020. It is now read-only.
Consumer cached proxy implementation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicoder10
suggested changes
Dec 10, 2019
|
Great job on this PR! I love this feature and implementation. Please address the comments. |
magicoder10
suggested changes
Dec 11, 2019
|
One last change. Impressive work! It's my honor to work with you! |
* Unit-testing FIRST principal * Fixed bug with loadKeys for maxCount > bufferSize
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
+ Coverage 66.66% 92.3% +25.64%
==========================================
Files 4 5 +1
Lines 69 104 +35
==========================================
+ Hits 46 96 +50
+ Misses 23 5 -18
- Partials 0 3 +3
Continue to review full report at Codecov.
|
magicoder10
suggested changes
Dec 12, 2019
| for ; maxCount > 0; maxCount-- { | ||
| // there is probability to get the list of keys with the size less than bufferSize | ||
| // in this case we listen to done channel to perform loop break | ||
| done := make(chan bool) |
There was a problem hiding this comment.
Suggested change
| done := make(chan bool) | |
| finishRefill := make(chan bool) |
| if len(p.buffer) == 0 { | ||
| go func() { | ||
| p.loadKeys() | ||
| done <- true |
There was a problem hiding this comment.
Suggested change
| done <- true | |
| finishRefill <- true |
| } | ||
|
|
||
| keys = append(keys, entry.key) | ||
| case <-done: |
There was a problem hiding this comment.
Suggested change
| case <-done: | |
| case <-finishRefill: |
magicoder10
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It resolves #30