Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserting padding in blank lines #48

Closed
eduardoarandah opened this issue Apr 2, 2020 · 1 comment · Fixed by #60
Closed

Inserting padding in blank lines #48

eduardoarandah opened this issue Apr 2, 2020 · 1 comment · Fixed by #60

Comments

@eduardoarandah
Copy link

Expected Behavior

Don't pad blank lines

Current Behavior

Pads new lines

Possible Solution

Delete all content in blank lines

Steps to Reproduce

  • Create a file with blank lines
  • blade-formatter --write --indent-size=8
  • Check padding in blank lines

Context (Environment)

Checked in VIM (where it doesn't trim blank lines by default)

Detailed Description

Check screenshot

image

This command messes up with vap in vim which "selects around paragraph"
image

Possible Implementation

Trim blank lines
shufo added a commit that referenced this issue Apr 11, 2020
@shufo
fix(formatter): do not insert padding in blankline
ab369bd 
closes #48
@shufo shufo mentioned this issue Apr 11, 2020
Merged
@shufo
Copy link
Owner

shufo commented Apr 11, 2020

published v1.1.5 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(formatter): do not insert padding in blankline shufo/blade-formatter
2 participants
@shufo @eduardoarandah