Merge pull request cosmos#71 from confio/rm-unused

Remove unused encoding code; move helpers to test code only
shuoer86 · Jan 31, 2022 · a48c323 · a48c323
2 parents 40f5d37 + 7786b70
commit a48c323
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 21 deletions.
diff --git a/js/src/ops.spec.ts b/js/src/ops.spec.ts
@@ -1,7 +1,7 @@
 import { ics23 } from "./generated/codecimpl";
 
-import { fromHex, toAscii } from "./helpers";
 import { applyInner, applyLeaf, doHash } from "./ops";
+import { fromHex, toAscii } from "./testhelpers.spec";
 
 describe("doHash", () => {
   it("sha256 hashes food", () => {

diff --git a/js/src/proofs.spec.ts b/js/src/proofs.spec.ts
@@ -1,7 +1,7 @@
 import { ics23 } from "./generated/codecimpl";
 
-import { fromHex, toAscii } from "./helpers";
 import { calculateExistenceRoot, ensureSpec, iavlSpec } from "./proofs";
+import { fromHex, toAscii } from "./testhelpers.spec";
 
 describe("calculateExistenceRoot", () => {
   it("must have at least one step", () => {

diff --git a/js/src/helpers.ts → js/src/testhelpers.spec.ts b/js/src/helpers.ts → js/src/testhelpers.spec.ts
@@ -33,21 +33,3 @@ export function toAscii(input: string): Uint8Array {
     });
   return Uint8Array.from(toNums(input));
 }
-
-export function fromAscii(data: Uint8Array): string {
-  const fromNums = (listOfNumbers: ReadonlyArray<number>) =>
-    listOfNumbers.map((x: number): string => {
-      // 0x00–0x1F control characters
-      // 0x20–0x7E printable characters
-      // 0x7F delete character
-      // 0x80–0xFF out of 7 bit ascii range
-      if (x < 0x20 || x > 0x7e) {
-        throw new Error(
-          "Cannot decode character that is out of printable ASCII range: " + x
-        );
-      }
-      return String.fromCharCode(x);
-    });
-
-  return fromNums(Array.from(data)).join("");
-}
diff --git a/js/src/testvectors.spec.ts b/js/src/testvectors.spec.ts
@@ -2,14 +2,14 @@ import { readFileSync } from "fs";
 
 import { compress } from "./compress";
 import { ics23 } from "./generated/codecimpl";
-import { fromHex } from "./helpers";
 import {
   batchVerifyMembership,
   batchVerifyNonMembership,
   verifyMembership,
   verifyNonMembership
 } from "./ics23";
 import { iavlSpec, tendermintSpec } from "./proofs";
+import { fromHex } from "./testhelpers.spec";
 
 describe("calculateExistenceRoot", () => {
   interface RefData {