-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add turso example #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kazy! I left some minor comments, but just cleanup, this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! ❤️ We'll merge this when we are ready to release your turso integration, which should be this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Kazy, so I noticed some things while doing my final test of this. The first is that this example is in the root of the repo, should we rather put it under axum similarly to how we do for other examples/resources? It will be less visible, but we can link to it from our docs.
Secondly I noticed that they have released several breaking changes since I tried this on friday, and I expect this to continue for a while since the library is so fresh. I'm thinking we should bump it to the latest version now (which will require minor changes in the resource integration), and then pin the version to the latest (=0.30.1). This way users won't have unexpected breakages from automatic upgrades. We're still going to have to upgrade it frequently, but it shouldn't be too much trouble, we can just release patch versions of the resource.
Hey @Kazy, I just addressed the final minor review since we are releasing this today. Thank you so much for this integration and example! |
@oddgrd I saw that, thank you for taking care of the last bits :) |
* feat: add turso example * ref(turso): remove unecessary things from the example * feat: move files, bump and lock version --------- Co-authored-by: oddgrd <[email protected]>
Example to go with shuttle-hq/shuttle#996.