Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add turso example #67

Merged
merged 3 commits into from
Jun 28, 2023
Merged

feat: add turso example #67

merged 3 commits into from
Jun 28, 2023

Conversation

Kazy
Copy link
Contributor

@Kazy Kazy commented Jun 26, 2023

Example to go with shuttle-hq/shuttle#996.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kazy! I left some minor comments, but just cleanup, this looks great!

turso/src/main.rs Outdated Show resolved Hide resolved
turso/Cargo.toml Outdated Show resolved Hide resolved
turso/Cargo.toml Outdated Show resolved Hide resolved
turso/Cargo.toml Outdated Show resolved Hide resolved
@Kazy Kazy requested a review from oddgrd June 26, 2023 11:37
Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ We'll merge this when we are ready to release your turso integration, which should be this week.

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kazy, so I noticed some things while doing my final test of this. The first is that this example is in the root of the repo, should we rather put it under axum similarly to how we do for other examples/resources? It will be less visible, but we can link to it from our docs.

Secondly I noticed that they have released several breaking changes since I tried this on friday, and I expect this to continue for a while since the library is so fresh. I'm thinking we should bump it to the latest version now (which will require minor changes in the resource integration), and then pin the version to the latest (=0.30.1). This way users won't have unexpected breakages from automatic upgrades. We're still going to have to upgrade it frequently, but it shouldn't be too much trouble, we can just release patch versions of the resource.

@oddgrd oddgrd merged commit a8cdf93 into shuttle-hq:main Jun 28, 2023
@Kazy Kazy deleted the turso-example branch June 28, 2023 08:59
@oddgrd
Copy link
Contributor

oddgrd commented Jun 28, 2023

Hey @Kazy, I just addressed the final minor review since we are releasing this today. Thank you so much for this integration and example!

@Kazy
Copy link
Contributor Author

Kazy commented Jun 28, 2023

@oddgrd I saw that, thank you for taking care of the last bits :)

AlphaKeks pushed a commit to AlphaKeks/shuttle-examples that referenced this pull request Aug 1, 2023
* feat: add turso example

* ref(turso): remove unecessary things from the example

* feat: move files, bump and lock version

---------

Co-authored-by: oddgrd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants