Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Version checks along the entire deployment chain #1110

Closed
1 task done
jonaro00 opened this issue Jul 27, 2023 · 1 comment · Fixed by #1275
Closed
1 task done

[Improvement]: Version checks along the entire deployment chain #1110

jonaro00 opened this issue Jul 27, 2023 · 1 comment · Fixed by #1275
Labels
S-Accepted This will be worked on T-Improvement Improvement or addition to existing features

Comments

@jonaro00
Copy link
Member

Describe the improvement

From #1053. The solution can build upon #1088.

It would be nice if the versions of

  • cargo-shuttle
  • the API (think shuttle-gateway)
  • (upcoming) builder
  • shuttle-deployer
  • shuttle-runtime of the user's project

were all logged and compatibility-checked throughout a deployment, with warnings for incompatible versions.

Duplicate declaration

  • I have searched the issues and this improvement has not been requested before.
@jonaro00 jonaro00 added T-Improvement Improvement or addition to existing features A-cargo-shuttle labels Jul 27, 2023
@jonaro00 jonaro00 added S-Investigation This issue needs further investigation or design to figure out a solution and removed A-deployer labels Aug 17, 2023
@jonaro00
Copy link
Member Author

Plan:

  • cargo-shuttle checks its version against the gateway's version in and endpoint.
  • gateway reads the container data and checks if a shuttle-deployer is outdated.
  • deployer checks if shuttle-runtime dep in user code is older/newer than deployer.
    All of the above result in a red/yellow text warning.

@jonaro00 jonaro00 added S-Accepted This will be worked on and removed S-Investigation This issue needs further investigation or design to figure out a solution labels Sep 25, 2023
@jonaro00 jonaro00 mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Accepted This will be worked on T-Improvement Improvement or addition to existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: version checks between cli, gateway, deployer, runtime jonaro00/shuttle
1 participant
@jonaro00