Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: version checks between cli, gateway, deployer, runtime #1275

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Sep 26, 2023

Description of change

Closes #1110, closes #1131

  • API has endpoint with the latest supported versions
  • cargo-shuttle warns about outdated or too new versions of self, deployer, and runtime.
    • it knows the version of self,
    • versions of deployer and runtime are parsed from the log stream and warned about if old ones are detected.
    • This is slightly different from the plan, where deployer would check the runtime version of the incoming project on deploy, but warnings in the middle of deployment logs will be hard to notice. Therefore, cargo-shuttle handles them and prints them at the end.
      • main disadvantage: the runtime warning will not reach user in some cases (i.e. 0.26 -> 0.27 changed runtime args, which crashes it too early)
  • Refactoring of cargo-shuttle commands to be more flexible.

How has this been tested? (if applicable)

All warnings have been tested by hardcoding older/newer versions in various places and verifying them.

@jonaro00 jonaro00 marked this pull request as ready for review September 26, 2023 11:23
cargo-shuttle/src/client.rs Show resolved Hide resolved
cargo-shuttle/src/lib.rs Outdated Show resolved Hide resolved
cargo-shuttle/src/lib.rs Show resolved Hide resolved
gateway/src/api/latest.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jonaro00 jonaro00 merged commit 538473a into shuttle-hq:main Sep 27, 2023
@jonaro00 jonaro00 deleted the feat/eng-1368-version-checks branch September 27, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants