Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: cargo +nightly sort --workspace fails #963

Closed
1 task done
paulotten opened this issue Jun 1, 2023 · 1 comment · Fixed by #966
Closed
1 task done

[Bug]: cargo +nightly sort --workspace fails #963

paulotten opened this issue Jun 1, 2023 · 1 comment · Fixed by #966
Assignees
Labels
T-Bug Something isn't working

Comments

@paulotten
Copy link
Contributor

What happened?

While running cargo +nightly sort --workspace as per CONTRIBUTING.md, we got the following error. It is not related to our changes, we haven't touched that file.

$ cargo +nightly sort --workspace
Checking shuttle...
Finished: Cargo.toml for "shuttle" has been rewritten
Checking admin...
Finished: Cargo.toml for "admin" has been rewritten
Checking auth...
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: TomlError { message: "TOML parse error at line 3, column 8\n  |\n3 | version.workspace = true\n  |        ^\nUnexpected `.`\nExpected `=`\n" }', /home/mike/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-sort-1.0.9/src/sort.rs:113:46
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

cargo-sort appears not to like/understand the period in version.workspace = true of line 3 of auth/Cargo.toml. I'm guessing this command hasn't been run in a while.

Version

head

Which operating system(s) are you seeing the problem on?

Linux

Which CPU architectures are you seeing the problem on?

No response

Relevant log output

No response

Duplicate declaration

  • I have searched the issues and there are none like this.
@paulotten paulotten added the T-Bug Something isn't working label Jun 1, 2023
@oddgrd
Copy link
Contributor

oddgrd commented Jun 2, 2023

Woops, this should have been removed from the contributing doc, as cargo-sort doesn't support workspace inheritance yet.

paulotten added a commit to mikegin/shuttle that referenced this issue Jun 2, 2023
@paulotten paulotten self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants