fix: mysql provisioning bug #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianbarbu
approved these changes
Jun 19, 2023
AlphaKeks
pushed a commit
to AlphaKeks/shuttle
that referenced
this pull request
Jun 20, 2023
* fix: mysql provisioning bug * docs: fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When we provision an rds database we use the engine name for the database name, this does not work for mysql. As a quick fix I changed it so mysql uses "msql" instead, because we currently don't have any mysql databases (it has not been possible). If we were to change the naming for all databases, we'd have to rename all the existing databases, which we don't want to prioritize right now.
How has this been tested? (if applicable)
Deployed the changes to unstable and deployed a mysql project. I might have uncovered a newer bug where a deployment with an rds database crashes (or incorrectly returns crashed) when it starts waiting for the rds instance to be ready, but looking at aws and provisioner logs the database did get successfully provisioned.
We need to renew the unstable certificate so we should do that and double check this PR works before merging.