fix(deployer): added runtime error handling #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orhun
reviewed
Sep 13, 2023
iulianbarbu
changed the base branch from
feat/shuttle-logger-service
to
main
iulianbarbu
force-pushed
the
fix/deployer-error-handling-2
branch
2 times, most recently
from
ecb9740 to
8de5040
Compare
iulianbarbu
force-pushed
the
fix/deployer-error-handling-2
branch
from
6d091e7 to
6e2e703
Compare
iulianbarbu
force-pushed
the
fix/deployer-error-handling-2
branch
from
6e2e703 to
f9475aa
Compare
jonaro00
approved these changes
Sep 29, 2023
oddgrd
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When user services are CPU bound the runtime logs stream handled by the deployer can break with a broken pipe error (I haven't confirmed the root cause yet because it is not that straightforward - big stack based on tonic, hyper, and h2, but I expect it to happen because the runtime becomes CPU bound and it can not respond in time to the client keep-alive messages, which will be followed by closing the corresponding end of the tonic channel), exiting the
runtask with panic.How has this been tested? (if applicable)
N/A