feat(installer): add installer script #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orhun
force-pushed
the
chore/add_installer_script
branch
from
d918b3d to
5a09bca
Compare
chesedo
approved these changes
Sep 28, 2023
|
Yup, it is not really needed. At first I thought we didn't have binary releases but we have so we can simply install them with this script. |
jonaro00
requested changes
Sep 28, 2023
jonaro00
reviewed
Sep 28, 2023
|
ready for re-review we also need to test this on MacOS before merge. |
jonaro00
approved these changes
Sep 29, 2023
oddgrd
approved these changes
Oct 2, 2023
Comment on lines
+6
to
+10
| _ _ _ _ | ||
| ___| |__ _ _| |_| |_| | ___ | ||
| / __| '_ \\| | | | __| __| |/ _ \\ | ||
| \__ \\ | | | |_| | |_| |_| | __/ | ||
| |___/_| |_|\\__,_|\\__|\\__|_|\\___| |
|
We should also update the readme in this repo with the fact that you can install with this script now, and we should add it to the installation guide in the docs repo. We should be clear about the fact that it doesn't work on windows yet. |
|
@oddgrd I can make those changes. (separate PRs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds the installer script for easily installing
cargo-shuttleon different platforms.Currently, it supports:
pacmancargo-binstall(ifcargo-binstallis installed)cargo install(installscargoviarustupif it is not found)How has this been tested? (if applicable)
On my local machine by running
./install.shWe need to test this on MacOS as well.