Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump and refactor images, code cleanup #1313

Merged
merged 16 commits into from
Nov 3, 2023
Merged

chore: bump and refactor images, code cleanup #1313

merged 16 commits into from
Nov 3, 2023

Conversation

jonaro00
Copy link
Member

@jonaro00 jonaro00 commented Oct 9, 2023 •
edited
Loading

Description of change

  • Bump stack's rust version to 1.73, CI and MSRV remains 1.72
  • Some refactorings to allow use of smaller images
  • Copy executable instead of move for faster redeploys

How has this been tested? (if applicable)

stack went up locally

@jonaro00 jonaro00 changed the title bump and refactor installations chore: bump and refactor images, use proto-gen Oct 18, 2023
@jonaro00 jonaro00 force-pushed the feat/minor-bumps branch 3 times, most recently from b62eb34 to 271b876 Compare October 19, 2023 16:39
@jonaro00 jonaro00 marked this pull request as ready for review October 20, 2023 10:15
@jonaro00 jonaro00 force-pushed the feat/minor-bumps branch 3 times, most recently from f8c4b6a to 4742981 Compare October 24, 2023 23:25
@jonaro00 jonaro00 changed the title chore: bump and refactor images, use proto-gen chore: bump and refactor images, code cleanup Nov 2, 2023
chesedo
chesedo reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

chesedo
chesedo approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@chesedo chesedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonaro00 jonaro00 merged commit 1c003cd into shuttle-hq:main Nov 3, 2023
@jonaro00 jonaro00 deleted the feat/minor-bumps branch November 3, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesedo chesedo chesedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaro00 @chesedo