feat: track project deployments #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
approved these changes
Jan 5, 2024
gateway/src/api/latest.rs
Outdated
Comment on lines
455
to
459
| let account_name = scoped_user.user.claim.sub.clone().to_string(); | ||
|
|
||
| tokio::spawn(async move { | ||
| let event = | ||
| async_posthog::Event::new("shuttle_api_start_deployment".to_string(), account_name); |
There was a problem hiding this comment.
Small nit:
Suggested change
| let account_name = scoped_user.user.claim.sub.clone().to_string(); | |
| tokio::spawn(async move { | |
| let event = | |
| async_posthog::Event::new("shuttle_api_start_deployment".to_string(), account_name); | |
| let account_name = scoped_user.user.claim.sub.clone(); | |
| tokio::spawn(async move { | |
| let event = | |
| async_posthog::Event::new("shuttle_api_start_deployment", &account_name); |
Co-authored-by: Oddbjørn Grødem <[email protected]>
…y' of https://github.com/GugaGongadze/shuttle into feature/eng-2122-track-start-deployment-event-in-gateway
GugaGongadze
deleted the
feature/eng-2122-track-start-deployment-event-in-gateway
branch
oddgrd
added a commit
that referenced
this pull request
Jan 8, 2024
* feat: track project deployments * test: test * Update gateway/src/api/latest.rs Co-authored-by: Oddbjørn Grødem <[email protected]> * fix: formatting --------- Co-authored-by: Oddbjørn Grødem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Moving tracking functionality in gateway, as opposed to doing it in deployer: #1485
How has this been tested? (if applicable)
shuttle_api_start_deploymentwas ingested by PostHog client.