feat(auth): add subscriptions table to auth, add rds quota to claim limits #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddgrd
changed the title
chesedo
reviewed
Jan 22, 2024
Kazy
reviewed
Jan 22, 2024
Provisioner is the only service using this field via the `Claim` since it and auth will be released at the same time, it is safe(ish) to remove this field.
Old runtimes will fail to deserialize if this field is not present. So marking it as deprecated will allow us to phase it out.
oddgrd
commented
Jan 22, 2024
| @@ -10,32 +10,44 @@ pub struct Limits { | |||
| /// The amount of projects this user can create. | |||
| project_limit: u32, | |||
| /// Whether this user has permission to provision RDS instances. | |||
| #[deprecated( | |||
| since = "0.38.0", | |||
There was a problem hiding this comment.
Nice! Should it be 0.37? The current version is 0.36.
Suggested change
| since = "0.38.0", | |
| since = "0.37.0", |
There was a problem hiding this comment.
I assumed this PR will only make it into the next release (if we release today) 🤷♂️
There was a problem hiding this comment.
We can update this if it is released earlier 😄
chesedo
deleted the
feature/engn-53-add-subscriptions-table-to-auth-update-jwt
branch
jonaro00
pushed a commit
that referenced
this pull request
Jan 24, 2024
…imits (#1529) * feat(auth): subscriptions table migration * feat(auth): update existing code to work with sub table * feat(common): add rds_quota to claim limits * feat(auth): refactor to two queries for user, * misc(auth): naming and migration comment * refactor: remove `rds_access` Provisioner is the only service using this field via the `Claim` since it and auth will be released at the same time, it is safe(ish) to remove this field. * refactor: improve comment * feat: added `create_at` data field * refactor: prevent uses of `rds_access` Old runtimes will fail to deserialize if this field is not present. So marking it as deprecated will allow us to phase it out. --------- Co-authored-by: chesedo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add a subscriptions table to auth to support multiple types of subscriptions, and update the claim limits with an rds quota.
How has this been tested? (if applicable)
Existing tests pass without modification, but new tests will be needed as we add functionality to add more than a pro subscription.