feat: beta deployment response, current deployment & logs #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaro00
force-pushed
the
deployment-response
branch
from
617a0c4 to
5978216
Compare
oddgrd
approved these changes
May 23, 2024
Kazy
approved these changes
May 23, 2024
| @@ -32,6 +32,8 @@ pub enum EcsState { | |||
| Stopped, | |||
| Stopping, | |||
| Failed, | |||
| /// Fallback | |||
| Unknown, | |||
There was a problem hiding this comment.
Do we really want to introduce that ? When can it happen ?
There was a problem hiding this comment.
Made it a fallback when we are parsing an ECS string response into the enum. We don't (yet) cover states that we don't expect to see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses fixed /current deployment endpoint for deployment status and logs command.
updates deployment response model with more relevant fields: