fix: dockerfile and ci improvements #989
Conversation
There was a problem hiding this comment.
Looks good @jonaro00 ! Only have a few comments with regards to some features that might become throw away work pretty soon (1/2 weeks timeframe at most). We can either merge the PR without them or wait a bit merging it until we'll be able to test it (and by that time we'll probably be really close with the the new builder). I think the best thing we can do is to address the comments and avoid merging the additional sscache and protoc from the deployer. What do you think?
|
EDIT: I overlooked that the shuttle-next installation needs to be after src cache layer, so I moved that part. The improvement is ~20s now. 😕 |
jonaro00
changed the title
| } | ||
| let profile = if release_mode { "release" } else { "dev" }; |
* cleanup in dockerfiles and ci * minor builder fixes * add sccache to deployer + cleanup * fmt * docs: install with --locked * Add comments, move arg statements * Leave out the sccache * clarify * Run prepare script before loading src cache * Delay src-dependent preparation to after cache * explicit docker.io, move curl installation --------- Co-authored-by: oddgrd <[email protected]>
Description of change
How has this been tested? (if applicable)
Tested some deploys with a minimal service.