Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Maven's managed dependencies #269

Merged
merged 1 commit into from
Jun 16, 2015
Merged

Use Maven's managed dependencies #269

merged 1 commit into from
Jun 16, 2015

Conversation

tomasz
Copy link
Contributor

@tomasz tomasz commented Jun 15, 2015

Declaring the mvvmfx-* artifacts in mvvmfx-parent's managed dependencies gives users a centralised version management for all mvvmfx-parent descendants. It's extensively explained in Maven docs.

But simply speaking, it puts the required version of all mvvmfx-* artifacts in one place. Users now can declare dependencies:

<dependencyManagement>
    <dependencies>
        <dependency>
            <groupId>de.saxsys</groupId>
            <artifactId>mvvmfx-parent</artifactId>
            <version>1.4.0-SNAPSHOT</version>
            <type>pom</type>
            <scope>import</scope>
        </dependency>
    </dependencies>
</dependencyManagement>

<dependencies>
    <dependency>
        <groupId>de.saxsys</groupId>
        <artifactId>mvvmfx</artifactId>
    </dependency>
    <dependency>
        <groupId>de.saxsys</groupId>
        <artifactId>mvvmfx-cdi</artifactId>
    </dependency>
    ...
</dependencies>

Although all other mvvmfx-* artifacts are listed in <managedDependencies> only the ones specifically listed in <dependencies> are actually used.

There is one drawback to this. The <scope>import</scope> attribute is only available in Maven 2.0.9 or later.

@manuel-mauky
Copy link
Collaborator

Hi tomasz,
thanks for your pull request. This looks interesting. I didn't know this maven feature.
I will have a look at your PR tomorrow.

manuel-mauky added a commit that referenced this pull request Jun 16, 2015
@manuel-mauky manuel-mauky merged commit 63afa96 into sialcasa:develop Jun 16, 2015
@manuel-mauky manuel-mauky added this to the 1.4.0 milestone Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants