feat: support MaxBatchSize #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks @vicary Pipeline Functions also support this. Could you please add it? Also, not that we still need to solve this issue before we can release a new version. I will try to find some time to look into this again |
|
@bboure Added support for Pipeline Resolvers! Please take your time on the new major, hopefully a new direction takes shape when you're working on it. Let me know when you have a new option syntax in your mind, I can help making a new PR for the new schema conversion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It caught me by surprise that MaxBachSize is not supported.
My project recently reached a point where we are actively exploring ways to squeeze out the last bits of performances, batching is definitely something worth trying.
It is also allowed in Direct Lambda Resolvers, scroll down to the section Direct Lambda Resolvers: Batching enabled to read more.