Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAMLConfigManager support #1446

Merged
merged 8 commits into from
Aug 19, 2019
Merged

Add YAMLConfigManager support #1446

merged 8 commits into from
Aug 19, 2019

Conversation

niveathika
Copy link
Member

Purpose

$subject fixes #1445

Goals

To support YAML Config Manager for easy setting of system properties in SiddhiManager

Approach

As in f3c8ea2

Release note

Add support YAML Config Manager for easy setting of system properties in SiddhiManager through a YAML file

Automation tests

  • Unit tests - Attached herewith
  • Integration tests - N/A

Security checks

Test environment

1.8.0_191

@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #1446 into master will increase coverage by <.01%.
The diff coverage is 73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1446      +/-   ##
============================================
+ Coverage     67.75%   67.76%   +<.01%     
  Complexity       41       41              
============================================
  Files           634      643       +9     
  Lines         26792    26892     +100     
  Branches       4232     4241       +9     
============================================
+ Hits          18154    18224      +70     
- Misses         6868     6891      +23     
- Partials       1770     1777       +7
Impacted Files Coverage Δ Complexity Δ
...dhi/core/exception/YAMLConfigManagerException.java 0% <0%> (ø) 0 <0> (?)
...va/io/siddhi/core/util/config/model/Extension.java 100% <100%> (ø) 0 <0> (?)
...a/io/siddhi/core/util/config/YAMLConfigReader.java 100% <100%> (ø) 0 <0> (?)
...ddhi/core/util/config/model/RootConfiguration.java 100% <100%> (ø) 0 <0> (?)
...va/io/siddhi/core/util/config/model/Reference.java 100% <100%> (ø) 0 <0> (?)
.../src/main/java/io/siddhi/core/util/FileReader.java 35.71% <35.71%> (ø) 0 <0> (?)
.../io/siddhi/core/util/config/YAMLConfigManager.java 80% <80%> (ø) 0 <0> (?)
...util/config/model/ReferenceChildConfiguration.java 87.5% <87.5%> (ø) 0 <0> (?)
...util/config/model/ExtensionChildConfiguration.java 87.5% <87.5%> (ø) 0 <0> (?)
.../siddhi/core/util/event/handler/StreamHandler.java 62% <0%> (-12%) 0% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30704d1...84e0d5e. Read the comment docs.

@niveathika niveathika merged commit 98ab6bf into siddhi-io:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for YAML file reader Config Manager
3 participants