Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update or insert in InMemoryTable using EventChunk #1503

Merged
merged 3 commits into from
Sep 18, 2019

Conversation

suhothayan
Copy link
Contributor

Purpose

Fix #1243

@codecov-io
Copy link

Codecov Report

Merging #1503 into master will increase coverage by 0.05%.
The diff coverage is 91.3%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1503      +/-   ##
============================================
+ Coverage     68.14%   68.19%   +0.05%     
  Complexity       42       42              
============================================
  Files           643      644       +1     
  Lines         26984    27028      +44     
  Branches       4260     4264       +4     
============================================
+ Hits          18387    18433      +46     
+ Misses         6813     6808       -5     
- Partials       1784     1787       +3
Impacted Files Coverage Δ Complexity Δ
...dhi/core/util/collection/operator/MapOperator.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../operator/OverwriteTableIndexOperatorForCache.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...llection/operator/OverwriteTableIndexOperator.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...e/util/collection/operator/CollectionOperator.java 17.64% <0%> (-0.27%) 0 <0> (ø)
...e/util/collection/operator/EventChunkOperator.java 18.98% <0%> (-0.25%) 0 <0> (ø)
...va/io/siddhi/core/util/parser/SiddhiAppParser.java 84.83% <100%> (ø) 0 <0> (ø) ⬇️
...i/core/util/collection/operator/IndexOperator.java 90.32% <100%> (ø) 0 <0> (ø) ⬇️
...ction/operator/SnapshotableEventQueueOperator.java 97.61% <100%> (+0.02%) 0 <0> (ø) ⬇️
.../main/java/io/siddhi/core/table/InMemoryTable.java 99.01% <100%> (+0.37%) 0 <0> (ø) ⬇️
...src/main/java/io/siddhi/core/table/CacheTable.java 96.37% <100%> (+0.13%) 0 <0> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6c9ee...a41ae6b. Read the comment docs.

@mohanvive mohanvive merged commit bdd0adb into siddhi-io:master Sep 18, 2019
@mohanvive mohanvive changed the title Fix update or insert in InMemoryTable using EventChuck Fix update or insert in InMemoryTable using EventChunk Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update or insert into InMemoryTable using event chunk that has updates within the chunk fails
3 participants