Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ondemand query error parsing #1588

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Conversation

niveathika
Copy link
Member

Purpose

$subject fix #969

Security checks

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #1588 into master will increase coverage by 0.01%.
The diff coverage is 90.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1588      +/-   ##
============================================
+ Coverage     67.71%   67.72%   +0.01%     
  Complexity       45       45              
============================================
  Files           650      651       +1     
  Lines         27478    27489      +11     
  Branches       4330     4335       +5     
============================================
+ Hits          18607    18618      +11     
+ Misses         7059     7057       -2     
- Partials       1812     1814       +2
Impacted Files Coverage Δ Complexity Δ
...io/siddhi/core/table/record/ExpressionBuilder.java 57.52% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/io/siddhi/core/SiddhiAppRuntimeImpl.java 63.1% <100%> (ø) 0 <0> (ø) ⬇️
...java/io/siddhi/core/config/SiddhiQueryContext.java 87.23% <100%> (+0.56%) 0 <0> (ø) ⬇️
.../java/io/siddhi/query/compiler/SiddhiCompiler.java 89.76% <100%> (+0.08%) 0 <0> (ø) ⬇️
...siddhi/core/util/parser/JoinInputStreamParser.java 81.69% <100%> (ø) 0 <0> (ø) ⬇️
...e/aggregation/IncrementalExecutorsInitialiser.java 51.94% <100%> (ø) 0 <0> (ø) ⬇️
...a/io/siddhi/core/util/parser/ExpressionParser.java 75.75% <100%> (ø) 0 <0> (ø) ⬇️
...ddhi/core/util/parser/SingleInputStreamParser.java 87.61% <100%> (ø) 0 <0> (ø) ⬇️
...siddhi/core/config/SiddhiOnDemandQueryContext.java 100% <100%> (ø) 0 <0> (?)
...o/siddhi/core/util/parser/OnDemandQueryParser.java 91.37% <100%> (ø) 0 <0> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d156169...dedca8b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store query parsing points to wrong siddhi app position when printing error log
4 participants