fix: wait for infra machine info to be collected before powering off #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkuozdemir
force-pushed
the
infra-machine-info-collect-before-power-off
branch
from
eb68e52 to
209d18b
Compare
frezbo
reviewed
Jan 3, 2025
frezbo
approved these changes
Jan 3, 2025
smira
approved these changes
Jan 8, 2025
utkuozdemir
force-pushed
the
infra-machine-info-collect-before-power-off
branch
from
209d18b to
2914976
Compare
There were cases when an infra machine was accepted, it was powered off by the infra provider too quickly, before its specs were populated by the `MachineStatus` poller. This caused additional issues as some other resources like `SchematicConfiguration` were also never created, blocking cluster creation. Address this by setting the preferred power state of the infra machine to ON until its status is populated (we check this by checking the secure boot status field). Additionally, clean up `InfraMachineConfig` resources (user-managed) when a machine is deleted. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
infra-machine-info-collect-before-power-off
branch
from
2914976 to
728897a
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were cases when an infra machine was accepted, it was powered off by the infra provider too quickly, before its specs were populated by the
MachineStatuspoller. This caused additional issues as some other resources likeSchematicConfigurationwere also never created, blocking cluster creation.Address this by setting the preferred power state of the infra machine to ON until its status is populated (we check this by checking the secure boot status field).
Additionally, clean up
InfraMachineConfigresources (user-managed) when a machine is deleted.Closes #798.