feat: implement infra machine reboot #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smira
approved these changes
Jan 8, 2025
Implement reboot functionality. The logic goes as follows: - When a user wants to reboot a server, they set a new unique `requested_reboot_id` on the `InfraMachineConfig` resource (for example, a UUID). - When the `InfraMachineStatus` resource gets updated with the `last_reboot_id` equal to the requested one, Omni knows that the reboot was processed. - The `last_reboot_timestamp` is updated by the infra provider when a machine is actually rebooted. The provider might or might not issue a reboot for each and every reboot request - if it had rebooted the machine too recently - but it will mark the request as "processed" by updating the `last_reboot_id`. Signed-off-by: Utku Ozdemir <[email protected]>
utkuozdemir
force-pushed
the
infra-machine-reboot
branch
from
2485398 to
1c4f9af
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement reboot functionality.
The logic goes as follows:
requested_reboot_idon theInfraMachineConfigresource (for example, a UUID).InfraMachineStatusresource gets updated with thelast_reboot_idequal to the requested one, Omni knows that the reboot was processed.last_reboot_timestampis updated by the infra provider when a machine is actually rebooted.The provider might or might not issue a reboot for each and every reboot request - if it had rebooted the machine too recently - but it will mark the request as "processed" by updating the
last_reboot_id.Part of #813.