fix: volume encryption with failing keyslots #9442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unix4ever
approved these changes
Oct 4, 2024
smira
force-pushed
the
fix/encryption-failed-key
branch
from
420b818 to
d4403c8
Compare
dsseng
approved these changes
Oct 4, 2024
smira
force-pushed
the
fix/encryption-failed-key
branch
from
d4403c8 to
50002fe
Compare
Fix the flow when a failing key slot leads to repeated attempts to open the volume, while it's already open, but the failure was to sync other keys. Refactor the code to get rid of variable assignment in the outer block from closures. Fixes siderolabs#9415 Signed-off-by: Andrey Smirnov <[email protected]>
smira
force-pushed
the
fix/encryption-failed-key
branch
from
50002fe to
0a2b455
Compare
|
/m |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the flow when a failing key slot leads to repeated attempts to open the volume, while it's already open, but the failure was to sync other keys.
Refactor the code to get rid of variable assignment in the outer block from closures.
Fixes #9415