-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: toolchain into multiple bldr packages #8
Conversation
wip, as I want to do a bit more testing before I consider it safe |
vars: | ||
BOOTSTRAP: /bootstrap | ||
|
||
binutils_version: 2.33.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got these exposed top-level to avoid duplication between multiple packages using same sources, and so that we can't forget to bump all of them
I'm just curious, what was the reason for dropping the |
I think it's not needed, because there's no way toolchain stages can be mixed now:
LFS does that, as both compilers are in the path as I understand (host and stage1), while for us it's not an issue |
SGTM. |
tested locally with |
There's one version bump: binutils is 2.33.1 as 2.31.1 had some bug reading compressed object data, not sure how it wasn't triggered before. Overview: * Alpine toolchain is used to build stage1 (bootstrap) binutils and gcc -> /boostrap * bootstrap musl is built (just to make programs compile) -> /bootstrap * bootstrap libstdcxx is built -> /bootstrap * musl is built -> /toolchain * binutils are built -> /toolchain * gcc is built -> /toolchain * linux-headers are built -> /toolchain * everything /toolchain is combined together Signed-off-by: Andrey Smirnov <[email protected]>
Pushed small update to remove |
@@ -74,8 +73,7 @@ ifneq ($(BUILDKIT_CONTAINER_RUNNING),$(BUILDKIT_CONTAINER_NAME)) | |||
--privileged \ | |||
-p 1234:1234 \ | |||
$(BUILDKIT_IMAGE) \ | |||
--addr $(BUILDKIT_HOST) \ | |||
--allow-insecure-entitlement security.insecure | |||
--addr $(BUILDKIT_HOST) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need --addr
, buildkit will respect BUILDKIT_HOST
env var, but we can clean this up later.
See siderolabs/toolchain#8 Also removes insecure entitlement from Makefile (copy-paste bug). Signed-off-by: Andrey Smirnov <[email protected]>
See siderolabs/toolchain#8 Also removes insecure entitlement from Makefile (copy-paste bug). Signed-off-by: Andrey Smirnov <[email protected]>
See siderolabs/toolchain#8, siderolabs/tools#82 Signed-off-by: Andrey Smirnov <[email protected]>
See siderolabs/toolchain#8, siderolabs/tools#82 Signed-off-by: Andrey Smirnov <[email protected]>
This also pulls in Go 1.13.3 See siderolabs/toolchain#8, siderolabs/tools#82, siderolabs/pkgs#69 Signed-off-by: Andrey Smirnov <[email protected]>
This also pulls in Go 1.13.3 See siderolabs/toolchain#8, siderolabs/tools#82, siderolabs/pkgs#69 Signed-off-by: Andrey Smirnov <[email protected]>
This also pulls in Go 1.13.3 See siderolabs/toolchain#8, siderolabs/tools#82, siderolabs/pkgs#69 Signed-off-by: Andrey Smirnov <[email protected]>
This also pulls in Go 1.13.3 See siderolabs/toolchain#8, siderolabs/tools#82, siderolabs/pkgs#69 Signed-off-by: Andrey Smirnov <[email protected]>
There's one version bump: binutils is 2.33.1 as 2.31.1 had some bug
reading compressed object data, not sure how it wasn't triggered before.
Overview:
and gcc -> /boostrap
Signed-off-by: Andrey Smirnov [email protected]