Update ruby version #592
Merged
Update ruby version #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siegfault
force-pushed
the
upgrade_ruby
branch
from
5c760d2 to
23daa3e
Compare
Initially upgrading with the hopes of fixing lemurheavy/coveralls-public#1240. Upgrading how we handle the versioning according to https://andycroll.com/ruby/read-ruby-version-in-your-gemfile/. Ran into rubyjs/therubyracer#467, so I ended up resolving it by switching to mini_racer via rubyjs/mini_racer#218 (comment).
siegfault
force-pushed
the
upgrade_ruby
branch
from
23daa3e to
46bf4b5
Compare
|
Just wanted to note that this PR helped me resolve an issue with upgrading ruby on my project here at Procore! Thanks @siegfault ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially upgrading with the hopes of fixing
lemurheavy/coveralls-public#1240.
Upgrading how we handle the versioning according to
https://andycroll.com/ruby/read-ruby-version-in-your-gemfile/.
Ran into rubyjs/therubyracer#467, so I ended
up resolving it by switching to mini_racer via
rubyjs/mini_racer#218 (comment).