Skip to content

Commit

Permalink
feat: add additional set of icons (#62)
Browse files Browse the repository at this point in the history
  • Loading branch information
silviowolf authored Jan 29, 2025
1 parent b0f30ed commit e24890a
Show file tree
Hide file tree
Showing 1,356 changed files with 2,629 additions and 551 deletions.
33 changes: 33 additions & 0 deletions .changeset/honest-monkeys-smile.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
'@siemens/ix-icons': major
---

- Add new set of icons
- Icon replacements:

| removed | replaced by |
| ---------------------------- | ---------------------------- |
| add-cirlce-small-filled | add-circle-small-filled |
| asset-network-1 | asset-network-filled |
| battery-bolt | battery-charge |
| battery-upright-bolt | battery-upright-charge |
| checkbox-component-checked | checkbox |
| corner-arrow-up-left | arrow-up-left |
| draw-cirlce | draw-circle |
| filter-outline | filter |
| folder-new-outline | folder-new |
| folder-open-outline | folder-open |
| folder-outline | folder |
| full-screeen-exit | full-screen-exit |
| full-screeen | full-screen |
| location-outline | location |
| new-indicator-filled | add-circle-small-filled |
| new-indicator | add-circle-small |
| no-anomaly | anomaly-none |
| plant-outline | plant |
| tag-cirlce-arrow-down | tag-circle-arrow-down |
| tag-cirlce-arrow-down-filled | tag-circle-arrow-down-filled |
| thumb-filled | thumb-down-filled |
| user-reading-reading | user-reading-filled |

- Icon `landing-page-logo` removed without an replacement
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- uses: ./.github/workflows/actions/build

Expand Down
28 changes: 28 additions & 0 deletions BREAKING_CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,34 @@ Previously, all icons were included within the icon package itself. This approac

With the release of version 3 of the main libraries @siemens/ix and @siemens/ix-icons, you now need to provide the icons as a static resource. This significantly reduces the bundle size.

## Remove misspelled and deprecated icons

| removed | replaced by |
| -------- | ------- |
| add-cirlce-small-filled | add-circle-small-filled |
| asset-network-1 | asset-network-filled |
| battery-bolt | battery-charge |
| battery-upright-bolt | battery-upright-charge |
| checkbox-component-checked | checkbox |
| corner-arrow-up-left | arrow-up-left |
| draw-cirlce | draw-circle |
| filter-outline | filter |
| folder-new-outline | folder-new |
| folder-open-outline | folder-open |
| folder-outline | folder |
| full-screeen-exit | full-screen-exit |
| full-screeen | full-screen |
| location-outline | location |
| new-indicator-filled | add-circle-small-filled |
| new-indicator | add-circle-small |
| no-anomaly | anomaly-none |
| plant-outline | plant |
| tag-cirlce-arrow-down | tag-circle-arrow-down |
| tag-cirlce-arrow-down-filled | tag-circle-arrow-down-filled |
| thumb-filled | thumb-down-filled |
| user-reading-reading | user-reading-filled |
| landing-page-logo | *-- no replacement --* |

# v2.0.0

Icon web fonts are removed.
42 changes: 23 additions & 19 deletions e2e/all-icon.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* LICENSE file in the root directory of this source tree.
*/

import { ConsoleMessage, expect, test } from '@playwright/test';
import { expect, test } from '@playwright/test';
import * as iconsFile from './sample.json';
import * as icons from './../icons';

Expand All @@ -29,25 +29,29 @@ function convertToCamelCase(value: string) {
const normalized = returnValue.replace(/\s+/g, '');
return normalized.charAt(0).toUpperCase() + normalized.slice(1);
}
test.describe.configure({ mode: 'serial' });

iconsFile.icons.forEach(iconName => {
test(`should show ${iconName}`, async ({ page }) => {
const dataUrlSvg = icons[`icon${convertToCamelCase(iconName)}`];
await page.goto(`http://127.0.0.1:8080/e2e/icon-by-name.html?icon=${iconName}`);

await page.evaluate(
([url]) => {
(window as any).__SVG_DATA__ = url;
},
[dataUrlSvg],
);

await page.waitForEvent('console', {
predicate: (message: ConsoleMessage) => {
return message.text() === 'icon-loaded-success';
},
const chunkSize = 100;

for (let i = 0; i < iconsFile.icons.length; i += chunkSize) {
const chunk = iconsFile.icons.slice(i, i + chunkSize);

test(`should match all icons ${i}/${iconsFile.icons.length}`, async ({ page }) => {
await page.goto('http://127.0.0.1:8080/e2e/all-icons.html');

const iconContentPage: string[] = [];

chunk.forEach(iconName => {
iconContentPage.push(`<p>${iconName}</p>`);
iconContentPage.push(`<ix-icon name="${iconName}"></ix-icon>`);
iconContentPage.push(`<ix-icon name="/www/build/svg/${iconName}.svg"></ix-icon>`);
iconContentPage.push(`<ix-icon name="${icons[`icon${convertToCamelCase(iconName)}`]}"></ix-icon>`);
});

expect(await page.locator('#mount').screenshot()).toMatchSnapshot();
await page.setContent(iconContentPage.join('\n'));

await expect(page).toHaveScreenshot({
fullPage: true,
});
});
});
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Loading

0 comments on commit e24890a

Please sign in to comment.