Made mjml_bin method aware of locally installed node_modules #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, testes are failing. I will require your assistance here @sighmon. :) |
|
Hey @hugogiraudel & @pgoetze, cool idea - we re-implemented it so that it locates the MJML executable and checks the version at require time to avoid crashing at runtime. We also avoided using What do you think? |
sighmon
pushed a commit
that referenced
this pull request
May 28, 2018
Replace backtick with Open3 for parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
The
mjml_binmethod currently returns the output ofwhich mjmlcommand, which works fine when the module is globally installed but would fail to retrieve a binary when only installed locally.This pull request intends to fix that by first checking the content of the
node_modulesfolder in the current Rails project, then falling back onwhichif there is no localmjml.One question though would be: do we have access to
Railsin this file?Ping @pgoetze.