-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 2860 #40
Conversation
The unit tests are failing since the commit 1e992b9 |
The authorization aspect will be added as part of ticket https://sightmachine.atlassian.net/browse/ENG-2934 . Authorization infra when in place will be used by all API's in SDK including get_raw_data. |
The unit tests are fixed @mklein0 . Can you review this change to enable merging. |
URL_V1 = "/v1/datatab/raw_data" | ||
|
||
|
||
def test_get_utilities(get_session): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just note that these tests are run against the demo ENV and will need to change if the env does
try: | ||
import importlib.resources as pkg_resources | ||
except ImportError: | ||
# Try backported to PY<37 `importlib_resources`. | ||
import importlib_resources as pkg_resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, PY3.7 is no longer a valid release.
raw_data_table (str) = 'cycle_raw_data'
timeselection (dict) = {"time_type":"relative","relative_start":1,"relative_unit":"day","ctime_tz":"America/Los_Angeles"}
select (list) = ['stats__ConveyorInput__val','stats__ConveyorOutput__val']
client.get_raw_data(raw_data_table, fields=select, time_selection=timeselection)