Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 2860 #40

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Eng 2860 #40

merged 8 commits into from
Oct 20, 2023

Conversation

ankitintg
Copy link
Contributor

@ankitintg ankitintg commented Sep 21, 2023

  • Implemented raw data endpoint functionality in SDK.
  • we can access raw_data now. An example is below-
    raw_data_table (str) = 'cycle_raw_data'
    timeselection (dict) = {"time_type":"relative","relative_start":1,"relative_unit":"day","ctime_tz":"America/Los_Angeles"}
    select (list) = ['stats__ConveyorInput__val','stats__ConveyorOutput__val']
    client.get_raw_data(raw_data_table, fields=select, time_selection=timeselection)
  • Integrated unit tests as well.

@mrnthv mrnthv requested review from mklein0 and mrnthv October 10, 2023 15:45
@mrnthv
Copy link
Contributor

mrnthv commented Oct 10, 2023

The unit tests are failing since the commit 1e992b9
We are looking into fixing them as part of ticket https://sightmachine.atlassian.net/browse/ENG-3115

@mrnthv
Copy link
Contributor

mrnthv commented Oct 10, 2023

The authorization aspect will be added as part of ticket https://sightmachine.atlassian.net/browse/ENG-2934 . Authorization infra when in place will be used by all API's in SDK including get_raw_data.

@mrnthv
Copy link
Contributor

mrnthv commented Oct 17, 2023

The unit tests are failing since the commit 1e992b9 We are looking into fixing them as part of ticket https://sightmachine.atlassian.net/browse/ENG-3115

The unit tests are fixed @mklein0 . Can you review this change to enable merging.

URL_V1 = "/v1/datatab/raw_data"


def test_get_utilities(get_session):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just note that these tests are run against the demo ENV and will need to change if the env does

smsdk/client.py Outdated Show resolved Hide resolved
Comment on lines +4 to +8
try:
import importlib.resources as pkg_resources
except ImportError:
# Try backported to PY<37 `importlib_resources`.
import importlib_resources as pkg_resources
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, PY3.7 is no longer a valid release.

@ankitintg ankitintg requested a review from mklein0 October 19, 2023 09:05
@ankitintg ankitintg merged commit 00a8c67 into master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants