Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-3443 | Fixed get_machine url params for v1 endpoints. #58

Merged
merged 5 commits into from
Dec 1, 2023
Merged

ENG-3443 | Fixed get_machine url params for v1 endpoints. #58

merged 5 commits into from
Dec 1, 2023

Conversation

ankitintg
Copy link
Contributor

@ankitintg ankitintg commented Nov 14, 2023 •
edited
Loading

Fix get_machines v1 endpoint url params.

Before the fix-

  • get_machines() was not able to use additional parameters such as where, order_by and select due to different way of implementation from v0 to v1 for machine endpoint.

After the fix

@ankitintg ankitintg requested a review from mrnthv November 14, 2023 07:40
@mrnthv mrnthv requested review from mklein0 and dfreidin November 21, 2023 19:10
mklein0
mklein0 reviewed Nov 22, 2023
View reviewed changes
Copy link

@mklein0 mklein0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need another codecov license for this PR.

smsdk/smsdk_entities/machine/machine_v1.py Show resolved Hide resolved
smsdk/smsdk_entities/machine/machine_v1.py Show resolved Hide resolved
tests/machine/test_machine.py Show resolved Hide resolved
@ankitintg ankitintg requested a review from mklein0 November 22, 2023 17:46
@ankitintg ankitintg merged commit 8fdb656 into master Dec 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoldmansight mgoldmansight mgoldmansight approved these changes

@mrnthv mrnthv Awaiting requested review from mrnthv

@dfreidin dfreidin Awaiting requested review from dfreidin

@mklein0 mklein0 Awaiting requested review from mklein0

Assignees

@mrnthv mrnthv

@mgoldmansight mgoldmansight

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankitintg @mklein0 @mgoldmansight @mrnthv