Releases/v1.26.0 branch: Implementation of SDK Version comparison for API's #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 20.30% 23.53% +3.23%
==========================================
Files 10 11 +1
Lines 1261 1351 +90
Branches 279 315 +36
==========================================
+ Hits 256 318 +62
- Misses 1005 1033 +28 ☔ View full report in Codecov by Sentry. |
mrnthv
changed the title
mklein0
reviewed
Dec 15, 2023
1) Refactored code to replace the global variable with a class attribute. 2) Implemented sorting of GitHub releases to obtain the latest version.
JMkrish
force-pushed
the
releases/v1.26.0
branch
from
009f930 to
128156d
Compare
JMkrish
force-pushed
the
releases/v1.26.0
branch
from
128156d to
27d84f0
Compare
mklein0
approved these changes
Dec 28, 2023
setup.py
Outdated
There was a problem hiding this comment.
FYI, I am going to suggest the creation of a new ticket to convert the python packaging from setup.py to the new pyproject.toml build system. The setup.py system has been deprecated.
mklein0
approved these changes
Jan 2, 2024
Comment on lines
+78
to
+79
| api_version_printed = False | ||
| last_version_check_time = None |
There was a problem hiding this comment.
FYI, do these need to be separate flags? Could have a method/property on the class which does the equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://sightmachine.atlassian.net/browse/ENG-3221